all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Andreas Enge <andreas@enge.fr>
Cc: "Ludovic Courtès" <ludo@gnu.org>,
	71947-done@debbugs.gnu.org,
	"Florian Pelz" <pelzflorian@pelzflorian.de>,
	"Matthew Trzcinski" <matt@excalamus.com>,
	"Christopher Baines" <mail@cbaines.net>
Subject: [bug#71947] [PATCH 0/2] Modify guix-build-coordinator-agent-service
Date: Sun, 22 Sep 2024 11:30:59 +0900	[thread overview]
Message-ID: <87o74gmnbw.fsf@gmail.com> (raw)
In-Reply-To: <ZuqcRu70cDDdSSU1@jurong> (Andreas Enge's message of "Wed, 18 Sep 2024 11:24:22 +0200")

Hi Andreas,

Andreas Enge <andreas@enge.fr> writes:

> Hello Maxim,
>
> Am Mon, Jul 08, 2024 at 10:40:40PM -0400 schrieb Maxim Cournoyer:
>> The above would have been best expressed by a maybe value using the
>> define-configuration scheme (but you'd have to migrate from the
>> define-record-type* to define-configuration first -- perhaps for another
>> time).
>
> thanks for the review, I have just pushed the patches.
> Since this is the first time I have touched a service, I contented myself
> with making minimal changes and not daring a bigger rewrite.

That's understandable.  Thanks for doing it all the same!

Cheers,

-- 
Maxim




  reply	other threads:[~2024-09-22  2:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-05 12:27 [bug#71947] [PATCH 0/2] Modify guix-build-coordinator-agent-service Andreas Enge
2024-07-05 12:32 ` [bug#71947] [PATCH 1/2] services: guix-build-coordinator-agent: Remove defaults Andreas Enge
2024-07-05 12:32 ` [bug#71947] [PATCH 2/2] services: guix-build-coordinator-agent: Add extra-options Andreas Enge
2024-07-09  2:40 ` [bug#71947] [PATCH 0/2] Modify guix-build-coordinator-agent-service Maxim Cournoyer
2024-09-18  9:24   ` bug#71947: " Andreas Enge
2024-09-22  2:30     ` Maxim Cournoyer [this message]
2024-07-09  2:41 ` [bug#71947] " Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o74gmnbw.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=71947-done@debbugs.gnu.org \
    --cc=andreas@enge.fr \
    --cc=ludo@gnu.org \
    --cc=mail@cbaines.net \
    --cc=matt@excalamus.com \
    --cc=pelzflorian@pelzflorian.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.