From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id CJznD1hqF2cV1gAAqHPOHw:P1 (envelope-from ) for ; Tue, 22 Oct 2024 09:03:20 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id CJznD1hqF2cV1gAAqHPOHw (envelope-from ) for ; Tue, 22 Oct 2024 11:03:20 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=k3Plv1Kq; dkim=fail ("headers rsa verify failed") header.d=us-core.com header.s=2017 header.b=I5CIqjUD; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=VJRtoEUO; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1729587800; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=a/34KflOrzhG96POvr5XYrzqZhWFxuQp8/FZmj5oYwI=; b=MtrbwScaKotdeBMwfw8rQfwbnlZp3SGAXGIgaaox4weZlufbUr8mzuX5ZZZVV6SegYpuch 5Oc4pae7JwWvUBf7YYijtw7Cn9/5WYiPAbQokI3RnKSnCkr6ylYiuRaKUJZ64hDGgRyI6k 4AaPJu0uepOWJqpvolVIcQlegiLsfK63DP4vpg80yyA54BOr8LoyM7MckNkG+abVaWavHJ qRhaft0eJJVeaFamZfXvw3t+lnt8IpcjSV8CZcSziWAsx/Xtc0tMxEloH7mMhW0VNxLteF lFFcXjLc97RlF0ej02vdCDGEINK9Tn3leG8+wKR12QAbWyORckIHjoMc85SDZQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=k3Plv1Kq; dkim=fail ("headers rsa verify failed") header.d=us-core.com header.s=2017 header.b=I5CIqjUD; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=VJRtoEUO; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1729587800; a=rsa-sha256; cv=none; b=okIQbkgZRLq8+EgUUA5CFd0i9YmfEqzxlxQtKNEyBYIc5JvRN4dhKEuy6S5zd4d4vRxD1W aE2a959obQjaaLDMRHOZK6CNP+b60iRq2yhG12t1O6+9sYWbGPZ2wt+LYJoZ7yLUdMhXUL 5hS5tqlw03DZz/lNVvfEu74Q7Q75jpTLy1XLJjXms6kZxzIrh32IpfdqQGSfrOyqTi3AAl 464N0r4NEvA9+xOPYxe8gPtZtd6aYgXlXN41JgrJD+pz18Dp1XlWWpdMgBzSClFO5HSGol Rd4cmhXzK//cP+wpVn3vE0vCpPtSNoAc+rcYxi4ptRXiFWZvKo6f4KMkzuDEBg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0C10D4142D for ; Tue, 22 Oct 2024 11:03:19 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3Amj-0000wN-W6; Tue, 22 Oct 2024 05:02:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3Amh-0000vN-JW for guix-patches@gnu.org; Tue, 22 Oct 2024 05:02:36 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t3Amg-0004UT-TN for guix-patches@gnu.org; Tue, 22 Oct 2024 05:02:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:In-Reply-To:References:Subject; bh=a/34KflOrzhG96POvr5XYrzqZhWFxuQp8/FZmj5oYwI=; b=k3Plv1KqrLy5Elr24/A4rCjNcBDyT9agzTnaI/juHuzz3iPjrvQUUSpKuWOrxrQ4GD3WqJHupbuzG9Z3lq4MYwZBTojRdzseZ6TqYG3FswlPtAP9x6NhAfNzc/nY8hTHjFCN5O8erFb3RWluQ1I/IwqJCdpeiRpCGTNHuW/9QlqjCGfB7GhRugrR2f4qN8gbKkpioZ84C9eeqT4UpnFz6wTwpc7IbQi7PB/P64BdipkMqdoD+x72FCSJwcJjOLugTVH2ESvlEkC3Jchcz9e3bNfJpAswLnFK/3ubHQHEHDPWDyTPw780KJgkgZ++sH1uBCrZbaA3n1+tANY561fHtQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t3An8-0007GT-5D for guix-patches@gnu.org; Tue, 22 Oct 2024 05:03:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#73839] comment on the new patchest References: <20241016120244.12778-1-shegeley@gmail.com> In-Reply-To: <20241016120244.12778-1-shegeley@gmail.com> Resent-From: Grigory Shepelev Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 22 Oct 2024 09:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73839 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 73839@patchwise.org, sharlatanus@gmail.com Received: via spool by 73839-submit@debbugs.gnu.org id=B73839.172958777527910 (code B ref 73839); Tue, 22 Oct 2024 09:03:02 +0000 Received: (at 73839) by debbugs.gnu.org; 22 Oct 2024 09:02:55 +0000 Received: from localhost ([127.0.0.1]:54631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t3An1-0007G5-6R for submit@debbugs.gnu.org; Tue, 22 Oct 2024 05:02:55 -0400 Received: from sail-ipv4.us-core.com ([208.82.101.137]:47376) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t3Amx-0007Ft-FV for 73839@debbugs.gnu.org; Tue, 22 Oct 2024 05:02:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=HI3VlVR8iCgvk84 RCRS77Hgy5FmgFkA/V//ICQ3pxT4=; h=date:subject:to:from; d=us-core.com; b=I5CIqjUD31j6GXFf0sSVuV9zeHK3SuwUNWiGhA2jnhLag6uz840UbUmmvkAykhlXRTgo A1w4rxCyJfF3IqpzDEXpcddjilvl4gPyVb4lgHyakEMqjYQB8Uli2UsDxuRUaV+2g3i26C NA6kECNVdbNVqrBoljGtgIBYRMxcmMk+A= Received: by localhost (OpenSMTPD) with ESMTPA id 5a20ec6e for <73839@debbugs.gnu.org>; Tue, 22 Oct 2024 09:02:20 +0000 (UTC) Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPS id d87909b4 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO) for <73839@patchwise.org>; Tue, 22 Oct 2024 09:02:19 +0000 (UTC) Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-539fbe22ac0so5966600e87.2 for <73839@patchwise.org>; Tue, 22 Oct 2024 02:02:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729587737; x=1730192537; darn=patchwise.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=a/34KflOrzhG96POvr5XYrzqZhWFxuQp8/FZmj5oYwI=; b=VJRtoEUOWP55h+RWU+Vk3UcXfamkTYqA0Op2tgoxwpAL/VXWhPtOYn7XTkQKr07Xd9 YGQ9V2u8GwKSwoB9fwFh/AClF2wQnYNMKdWi1m4y07t7q1i3BAuNzoQeUQNzrEP48w4j 2FzCPgB6mnP5VX0GNZjBtvc+/WNsd9bwAw75weSMn4ABqOGwk1oc6HqXCBwZnv5Zm6nc Gmhk3FawMeRdzJIni3BwUucWvZU3qrGzTL4/oBrw+Dv4DsPBt2MX0NKSJjkHIkeZhVdR i5hYeZhR6iothvHowbLxYsUCCoTfdgC52AXD4BSbB4FW8C0sTHyKnSWtR3vKK88bL7aH W7BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729587737; x=1730192537; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=a/34KflOrzhG96POvr5XYrzqZhWFxuQp8/FZmj5oYwI=; b=uRb8StNOdAuxQgyAsoCTLmLILY1moOkCwLQbwECnQ9idQcZR2AFvJfUhU/7eN5CYEf 7W/WlR07ioyIxeI1o74VWxJMPalh5f7a5/r+Fkq4ZMvjHitGGx3NhKeGxnKXcFyHucRf zKU7elJFJa3gu4ySZmwnk1cYpSCF1/JM1rHhu2FgjFvw9+nrj4FBadMGOkccu3gyjjZu HgbzQkhx2LgTaKkw8YdJ8dyEEL2VVga/9z7IgWFpjPW8K6v/Zk9xxYSj5RBzVZd2tFfX ELlfUvVJY4ahCcpH9Z3AirQtagMU0XtS/WF2CKnRINBQREUOClOjDwQ6QYeDC980oHAD zAlA== X-Gm-Message-State: AOJu0YwWFugOtHP5Sl0VNw4AR2WTAJciumtaTEJ+Aq937O+lN1qa6DGD +fWRZIz/KqHoFLIqI1gAFbgjrypqSZFcifVkUCsmrL/rLPSTtz04BLx/EXvE X-Google-Smtp-Source: AGHT+IHzMlOWDAnaDJStmZqgsffIi/L7v8mtL3YdYAE/xa2cQ40vDXGuEc5ilVrFUS58etJ2xJLVfA== X-Received: by 2002:a05:6512:b11:b0:539:fda6:fa0a with SMTP id 2adb3069b0e04-53a1520b243mr6402958e87.9.1729587737183; Tue, 22 Oct 2024 02:02:17 -0700 (PDT) Received: from localhost ([46.172.4.246]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53a223f015fsm714398e87.109.2024.10.22.02.02.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2024 02:02:15 -0700 (PDT) From: Grigory Shepelev Date: Tue, 22 Oct 2024 12:02:13 +0300 Message-ID: <87o73c7boq.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx11.migadu.com X-Migadu-Spam-Score: 3.26 X-Spam-Score: 3.26 X-Migadu-Queue-Id: 0C10D4142D X-TUID: yvfV34rRjcnQ Execuse me. I wanted to add comment in every patch on what's changed, but failed because I'm new with git+email workflow. Had to add this message. Mostly the fixes are as you've mentioned 1. Move hash out of upper let 2. Move test inputs to native-inputs 3. Fix/add description where it's relevant 4. `search-inputs` -> `this-package-inputs/native-inputs` where possible 5. guix style all of them Coundn't figure out cl transformations for cl-pango (sbcl-package->[cl/ecl]-source-package sbcl-cl-pango) will fail with "error: sbcl-xmls: unbound variable". Seems like there is no cl transformations for sbcl-xmls which is an input. This message and patches were sent to patchwise.org, not guix debuggs cos access to the guix domain are unstable in my country. I hope it's not a problem. -- Best regards, Grigory Shepelev