From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id CKdALqAvM2daXAEAqHPOHw:P1 (envelope-from ) for ; Tue, 12 Nov 2024 10:36:16 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id CKdALqAvM2daXAEAqHPOHw (envelope-from ) for ; Tue, 12 Nov 2024 11:36:16 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=rxPfEozi; dkim=fail ("headers rsa verify failed") header.d=inria.fr header.s=dc header.b=MFBLecDc; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=inria.fr (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1731407776; a=rsa-sha256; cv=none; b=HwoNuAkPDQbmJs1mO0qBK36lQ8nPwD0x/i+IiEykE3ORkNPU5EU+srfNoXd5nwd7xaJyQV ruZ+XMFBpYkSMrjRayKxhl2++i/LmABFtXSsNPdJOgOo8kUf86j8wmjSFvyS8YUczXUpRS ukMqxqDkc1mwWrT56GO0yibOwcDNBuebbW+qhndNGxErBugX+HEKrfDIAf65ndIcXEx+Px 2wJ+fI35TkNg7beLgzr1RY11Wa21HNi3ru7NUlaCI8P7O5xEEBmaBOQDII5cAtGeae5lJg yMcwjazZ/ixjy4/0tq2Iuz4GK9ld0ttPen1aKjjiiBJ4PdOpKHqR8vszQVY3fA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=rxPfEozi; dkim=fail ("headers rsa verify failed") header.d=inria.fr header.s=dc header.b=MFBLecDc; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=inria.fr (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1731407776; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=d+pgSTJtYSjFG11o8v1fwY0tE+HkCDMEMG040bUG8Aw=; b=RUJ2tkYOpd+SwcF4BCXFiqOjfsBXOZh2iSLH7LSO6+5n9mCM16fbGKbeFP96x5JN4giiAt IQWNWyjASHN0MIQtiDGEoMur3gHmbyL7Ky20G4BQxdtXFo8moMiQXQMGQ5P3jYn09AMRNV /mTVm09vqTH1dVipXhaptoJiHSsFgdgCYzcvKhs9sltxWMt6vvtvFhnbdq4QwLQIn65DGi AjoQz9T/LW/37B6rbKll6YXJio9F60LQA0c3wLf6mia5r2abbAkr0ZvdtbK32jnI60Qa5L Zz/s+OYCnjErQhct8f6lpuZ9sA3X09hmSCWcLa3IUvc3omEa81LP5MPp9JJ2aQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5F8A787F7F for ; Tue, 12 Nov 2024 11:36:15 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tAoFi-0002Oj-8W; Tue, 12 Nov 2024 05:36:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tAoFf-0002Oa-Nz for guix-patches@gnu.org; Tue, 12 Nov 2024 05:36:03 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tAoFd-00029U-S0 for guix-patches@gnu.org; Tue, 12 Nov 2024 05:36:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=d+pgSTJtYSjFG11o8v1fwY0tE+HkCDMEMG040bUG8Aw=; b=rxPfEozibmGxphqMrhxs2Luu6+yMAEQ1rFLBnssFYQ+Th3wVa4Qk47bdW4fsRDaQczTdYj9ruF3LFBuoUucR9Jlf6WeXCCI2FxdgT68Y6uTs+q8WjVlLJ7qLMu2AOdKtHMP5wQBhpaqGhlOylTKHEun3MdcCel4ZPU5qiQbRBNE2kh34o+4wkzu8HgcXAJbjM+6m6qSRTmD6jLXIBOHMPGr9Kb+DgbSRtqpoTbVfdQNQ0hcCjvCIR66X2u4afx0c98L8rmO3I3tYnoByH6WCuvyW6w9Z0GvCFg9fyvmbKsOBBsT6Iz07TVBgKStILLCcUdIGyGHCm5JlYUdvglxYag==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tAoFd-00083g-LK for guix-patches@gnu.org; Tue, 12 Nov 2024 05:36:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#72766] [PATCH v4] gnu: slurm: Enable REST API. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 12 Nov 2024 10:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72766 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Arun Isaac Cc: 72766@debbugs.gnu.org Received: via spool by 72766-submit@debbugs.gnu.org id=B72766.173140776030969 (code B ref 72766); Tue, 12 Nov 2024 10:36:01 +0000 Received: (at 72766) by debbugs.gnu.org; 12 Nov 2024 10:36:00 +0000 Received: from localhost ([127.0.0.1]:60747 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAoFb-00083R-Nl for submit@debbugs.gnu.org; Tue, 12 Nov 2024 05:36:00 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:46432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAoFZ-00083D-Ox for 72766@debbugs.gnu.org; Tue, 12 Nov 2024 05:35:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=d+pgSTJtYSjFG11o8v1fwY0tE+HkCDMEMG040bUG8Aw=; b=MFBLecDczgEtKbyatyWQJ+LMl4UYV76PkrBTWNi0HK8qR8Q1r/8D7IOy oJ+jA9IoeBv34Ug4EHjANMVNEet62sqrdyknf5xl09VmFlIuycckTo3oC TvGsQxSXp91EfDdVZsbRLzmCKzX+N9y7WKGqXeV+XCnr8pDiuHNj55PnT 0=; X-IronPort-AV: E=Sophos;i="6.12,147,1728943200"; d="scan'208";a="193325440" Received: from unknown (HELO ribbon) ([193.50.110.122]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Nov 2024 11:35:52 +0100 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <64fa0bf0f949a50512b2dc91ed436a5e96d71a77.1729869863.git.arunisaac@systemreboot.net> (Arun Isaac's message of "Fri, 25 Oct 2024 16:24:30 +0100") References: <64fa0bf0f949a50512b2dc91ed436a5e96d71a77.1729869863.git.arunisaac@systemreboot.net> Date: Tue, 12 Nov 2024 11:35:51 +0100 Message-ID: <87o72ku4c8.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -1.31 X-Spam-Score: -1.31 X-Migadu-Queue-Id: 5F8A787F7F X-Migadu-Scanner: mx12.migadu.com X-TUID: /pKIA6SaVmye Hello, Arun Isaac skribis: > Rename slurm and slurm-* to slurm-minimal and slurm-minimal-*. Add new sl= urm > packages that inherit from slurm-minimal and have the REST API enabled. > > * gnu/packages/parallel.scm (make-slurm): New function. > (slurm-minimal, slurm-minimal-23.02, slurm-minimal-22.05, slurm-minimal-2= 1.08, > slurm-minimal-20.11, slurm-minimal-20.02, slurm-minimal-19.05, > slurm-minimal-18.08): New variables. > (slurm, slurm-23.02, slurm-22.05, slurm-21.08, slurm-20.11, slurm-20.02, > slurm-19.05, slurm-18.08): Inherit from slurm-minimal, slurm-minimal-23.0= 2, > slurm-minimal-22.05, slurm-minimal-21.08, slurm-minimal-20.11, > slurm-minimal-20.02, slurm-minimal-19.05 and slurm-minimal-18.08 respecti= vely. > > Change-Id: I6410ac385d8876f4b6a908ddb1272172475a87bb [...] > +(define (make-slurm base-slurm) > + "Make a slurm package with all optional features enabled. Base it off = of the > +minimal slurm package BASE-SLURM." > + (package > + (inherit base-slurm) > + (name "slurm") > + (arguments > + (substitute-keyword-arguments (package-arguments base-slurm) > + ((#:configure-flags flags #~'()) > + #~(cons* "--enable-slurmrestd" > + (string-append "--with-bpf=3D" > + (dirname > + (dirname (search-input-directory > + %build-inputs "include/linux"= )))) > + (string-append "--with-http-parser=3D" > + #$(this-package-input "http-parser")) > + (string-append "--with-rdkafka=3D" > + #$(this-package-input "librdkafka")) > + (string-append "--with-yaml=3D" > + #$(this-package-input "libyaml")) > + #$flags)))) > + ;; FIXME: More optional inputs could be added. > + (inputs > + (modify-inputs (package-inputs base-slurm) > + (prepend dbus freeipmi http-parser > + libjwt librdkafka libyaml (list mariadb "dev")))))) Could you add a comment and/or synopsis stating that these dependencies enable support for the REST API? Otherwise LGTM. Feel free to commit with this change. Thanks! Ludo=E2=80=99.=20