From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark H Weaver <mhw@netris.org>
Subject: Re: [PATCH] gnu: gnunet: Add GNUnet-0.10.0.
Date: Fri, 31 Jan 2014 11:17:14 -0500
Message-ID: <87mwicdt2t.fsf@netris.org>
References: <52EAE140.8090805@totakura.in>
	<1391124816-31500-1-git-send-email-sreeharsha@totakura.in>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43344)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1W9Gmu-00024P-KR
	for guix-devel@gnu.org; Fri, 31 Jan 2014 11:17:58 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1W9Gmo-0003tK-EI
	for guix-devel@gnu.org; Fri, 31 Jan 2014 11:17:52 -0500
Received: from world.peace.net ([96.39.62.75]:41018)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1W9Gmo-0003rU-9u
	for guix-devel@gnu.org; Fri, 31 Jan 2014 11:17:46 -0500
In-Reply-To: <1391124816-31500-1-git-send-email-sreeharsha@totakura.in> (Sree
	Harsha Totakura's message of "Fri, 31 Jan 2014 00:33:36 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Sree Harsha Totakura <sreeharsha@totakura.in>
Cc: guix-devel@gnu.org

Hi,

Sree Harsha Totakura <sreeharsha@totakura.in> writes:
> +    '(#:phases
> +        ;; swap check and install phases and set paths to installed binaries
> +        (alist-cons-before
> +         'check 'set-path-for-check
> +         (lambda* (#:key outputs #:allow-other-keys)
> +          (let ((out (assoc-ref outputs "out")))
> +           (setenv "GNUNET_PREFIX" out)
> +           (setenv "PATH" (string-append (getenv "PATH") ":" out "/bin"))))
> +        (alist-cons-after
> +         'install 'check
> +         (assoc-ref %standard-phases 'check)
> +        (alist-delete
> +         'check
> +        %standard-phases)))))

The indentation of this part (authored by Andreas) is misleading.  It
looks as though the calls to 'alist-*' are sibling expressions, when in
fact they are nested within each other.  I suspect this was intentional,
but IMO it's a bad idea to play such games with indentation.  I think it
should be like this:

--8<---------------cut here---------------start------------->8---
    '(#:phases
        ;; swap check and install phases and set paths to installed binaries
        (alist-cons-before
         'check 'set-path-for-check
         (lambda* (#:key outputs #:allow-other-keys)
          (let ((out (assoc-ref outputs "out")))
           (setenv "GNUNET_PREFIX" out)
           (setenv "PATH" (string-append (getenv "PATH") ":" out "/bin"))))
         (alist-cons-after
          'install 'check
          (assoc-ref %standard-phases 'check)
          (alist-delete
           'check
           %standard-phases)))))
--8<---------------cut here---------------end--------------->8---

What do you think?

      Mark