From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 2/2] gnu: Add jrnl.
Date: Mon, 30 Jun 2014 12:59:23 +0200
Message-ID: <87mwcu3bp0.fsf@gnu.org>
References: <CADwNbn9MBFfW9rEDAsM_FoBt-5oNQg+6dci3CvLARu-1D5FSUw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59903)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1X1ZJ4-0005lK-3v
	for guix-devel@gnu.org; Mon, 30 Jun 2014 06:59:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1X1ZIz-0007BJ-P8
	for guix-devel@gnu.org; Mon, 30 Jun 2014 06:59:30 -0400
Received: from hera.aquilenet.fr ([2a01:474::1]:53604)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1X1ZIz-00079r-I7
	for guix-devel@gnu.org; Mon, 30 Jun 2014 06:59:25 -0400
In-Reply-To: <CADwNbn9MBFfW9rEDAsM_FoBt-5oNQg+6dci3CvLARu-1D5FSUw@mail.gmail.com>
	(Eric Bavier's message of "Mon, 30 Jun 2014 00:51:08 -0500")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Eric Bavier <ericbavier@gmail.com>
Cc: guix-devel@gnu.org

Eric Bavier <ericbavier@gmail.com> skribis:

> From d2131f9ddbbac601d3915b815fa58bce05b5d663 Mon Sep 17 00:00:00 2001
> From: Eric Bavier <bavier@member.fsf.org>
> Date: Mon, 30 Jun 2014 00:28:40 -0500
> Subject: [PATCH 2/2] gnu: Add jrnl.
>
> * gnu/packages/jrnl.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
> * gnu/packages/python.scm (python-pycrypto, python-keyring, python-dateut=
il-2,
>   python-parsedatetime, python-tzlocal): New variables.
> * guix/licenses.scm (cc0): New variable.

OK, but could you make the addition of cc0 a separate commit?

> +    (home-page "http://maebert.github.io/jrnl/")
> +    (synopsis "Journal application")

Maybe =E2=80=9CNote-taking and journal application=E2=80=9D?  (I wasn=E2=80=
=99t sure what
=E2=80=9Cjournal=E2=80=9D meant here.)

> +    (license (x11-style "file://LICENSE"))))

AFAICS it is exactly the MIT/X11 license:

  https://github.com/maebert/jrnl/blob/master/LICENSE

Thus, could you change it =E2=80=98x11=E2=80=99?

(There was another one like this in the Behave patch, but I didn=E2=80=99t
check.)

> +    (synopsis
> +     "Extensions to the standard datetime module, available in Python 2.=
3+")

Remove =E2=80=9C, available in Python 2.3+=E2=80=9D.

OK to push with these changes.

Thanks!

Ludo=E2=80=99.