From: ludo@gnu.org (Ludovic Courtès)
To: Eric Bavier <ericbavier@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/2] gnu: Add jrnl.
Date: Mon, 30 Jun 2014 12:59:23 +0200 [thread overview]
Message-ID: <87mwcu3bp0.fsf@gnu.org> (raw)
In-Reply-To: <CADwNbn9MBFfW9rEDAsM_FoBt-5oNQg+6dci3CvLARu-1D5FSUw@mail.gmail.com> (Eric Bavier's message of "Mon, 30 Jun 2014 00:51:08 -0500")
Eric Bavier <ericbavier@gmail.com> skribis:
> From d2131f9ddbbac601d3915b815fa58bce05b5d663 Mon Sep 17 00:00:00 2001
> From: Eric Bavier <bavier@member.fsf.org>
> Date: Mon, 30 Jun 2014 00:28:40 -0500
> Subject: [PATCH 2/2] gnu: Add jrnl.
>
> * gnu/packages/jrnl.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
> * gnu/packages/python.scm (python-pycrypto, python-keyring, python-dateutil-2,
> python-parsedatetime, python-tzlocal): New variables.
> * guix/licenses.scm (cc0): New variable.
OK, but could you make the addition of cc0 a separate commit?
> + (home-page "http://maebert.github.io/jrnl/")
> + (synopsis "Journal application")
Maybe “Note-taking and journal application”? (I wasn’t sure what
“journal” meant here.)
> + (license (x11-style "file://LICENSE"))))
AFAICS it is exactly the MIT/X11 license:
https://github.com/maebert/jrnl/blob/master/LICENSE
Thus, could you change it ‘x11’?
(There was another one like this in the Behave patch, but I didn’t
check.)
> + (synopsis
> + "Extensions to the standard datetime module, available in Python 2.3+")
Remove “, available in Python 2.3+”.
OK to push with these changes.
Thanks!
Ludo’.
next prev parent reply other threads:[~2014-06-30 10:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 5:51 [PATCH 2/2] gnu: Add jrnl Eric Bavier
2014-06-30 10:59 ` Ludovic Courtès [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-06-30 5:44 Eric Bavier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mwcu3bp0.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=ericbavier@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.