Re: [PATCH 5/5] gnu: Some cleanup based on lint checkers.

[Eric Bavier <ericbavier@gmail.com>]

Ludovic Courtès writes:

> Eric Bavier <ericbavier@gmail.com> skribis:
>> 2. Many descriptions begin with the package name in lowercase form,
>> which triggers a warning about the description beginning with a
>> lowercase letter.  In this patch I capitalised the package name if I
>> could find a reference to the capital form on the package's home-page
>> somewhere.  Many packages are quite insistent that the package always be
>> referenced by the lowercase name, and I'm not sure how the description
>> would be reworded, or whether it really needs to be.  We could add an
>> exception to the description-starts-with-a-capital-letter rule for when
>> the package name is the first word.
>
> Yes, sounds like a good idea.

I'll do this in an updated patch.

>> 3. Some synopses begin with a numeral, triggering the capital-letter
>> warning.
>
> guile -c '(use-modules(guix)(gnu)(ice-9 regex))(fold-packages (lambda (p r) (if (and (package-synopsis p) (string-match "^[0-9]" (package-synopsis p))) (cons p r) r)) (list))'
>
> returns the empty list.  Which one was it?

E.g. linux-libre, fltk, and cairo.

>> Comments welcome.  Nitpicks especially, since much of this is already
>> quite nitpicky. ;)
>
> I was wondering who was going to take care of that now that we have all
> these fancy checkers, so thank you!  :-)
>
> I skimmed through it and I think you can commit it.  If ‘make
> sync-description’ is unhappy, we should see what’s going on, and
> possibly amend the upstream description if needed.

I forgot about sync-description here.  I will check that.

-- 
Eric Bavier

Please avoid sending me Word or PowerPoint attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html