From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add Wine.
Date: Sun, 16 Nov 2014 18:27:05 +0100
Message-ID: <87mw7rf446.fsf@gnu.org>
References: <1416062479-26430-1-git-send-email-iyzsong@gmail.com>
	<87sihkiatr.fsf@gnu.org> <874mtzrgrt.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60663)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Xq3bY-0000Mv-Ul
	for guix-devel@gnu.org; Sun, 16 Nov 2014 12:27:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Xq3bP-0003nD-Uh
	for guix-devel@gnu.org; Sun, 16 Nov 2014 12:27:16 -0500
Received: from hera.aquilenet.fr ([2a01:474::1]:57930)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1Xq3bP-0003n9-OF
	for guix-devel@gnu.org; Sun, 16 Nov 2014 12:27:07 -0500
In-Reply-To: <874mtzrgrt.fsf@gmail.com> (=?utf-8?B?IuWui+aWh+atpiIncw==?=
	message of "Sun, 16 Nov 2014 11:00:38 +0800")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@gmail.com>
Cc: guix-devel@gnu.org

=E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@gmail.com> skribis:

> I can't get tests working, so leave them disabled.

It=E2=80=99s OK to do that so we can move forward, but please leave a comme=
nt
that explains the situation, above #:tests? #f.  The goal remains to
have tests running, eventually.

> +    (arguments
> +     `(#:system "i686-linux"

No, that=E2=80=99s not possible.  :-)
People should be able to use Wine regardless of their platform.

What is the reason behind it?

If some platforms are inherently not supported by Wine, then please add
a =E2=80=98supported-platforms=E2=80=99 field (there are examples in other =
files.)

The rest looks good to me.

Thanks,
Ludo=E2=80=99.