From: ludo@gnu.org (Ludovic Courtès)
To: 宋文武 <iyzsong@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add Wine.
Date: Sun, 16 Nov 2014 18:27:05 +0100 [thread overview]
Message-ID: <87mw7rf446.fsf@gnu.org> (raw)
In-Reply-To: <874mtzrgrt.fsf@gmail.com> ("宋文武"'s message of "Sun, 16 Nov 2014 11:00:38 +0800")
宋文武 <iyzsong@gmail.com> skribis:
> I can't get tests working, so leave them disabled.
It’s OK to do that so we can move forward, but please leave a comment
that explains the situation, above #:tests? #f. The goal remains to
have tests running, eventually.
> + (arguments
> + `(#:system "i686-linux"
No, that’s not possible. :-)
People should be able to use Wine regardless of their platform.
What is the reason behind it?
If some platforms are inherently not supported by Wine, then please add
a ‘supported-platforms’ field (there are examples in other files.)
The rest looks good to me.
Thanks,
Ludo’.
next prev parent reply other threads:[~2014-11-16 17:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-15 14:41 [PATCH] gnu: Add Wine 宋文武
2014-11-15 14:45 ` John Darrington
2014-11-15 15:05 ` Bruno Félix Rezende Ribeiro
2014-11-15 15:48 ` John Darrington
2014-11-15 16:47 ` Bruno Félix Rezende Ribeiro
2014-11-15 17:01 ` John Darrington
2014-11-15 15:10 ` 宋文武
2014-11-15 15:02 ` 宋文武
2014-11-15 18:15 ` Ludovic Courtès
2014-11-15 16:39 ` 宋文武
2014-11-15 18:21 ` Ludovic Courtès
2014-11-16 3:00 ` 宋文武
2014-11-16 17:27 ` Ludovic Courtès [this message]
2014-11-17 12:34 ` 宋文武
2014-11-17 13:30 ` Ludovic Courtès
2014-11-18 21:32 ` Ludovic Courtès
2014-11-19 11:38 ` 宋文武
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mw7rf446.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=iyzsong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.