From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Thompson Subject: Re: [PATCH] Update ncmpcpp to v0.6.2 Date: Fri, 27 Feb 2015 12:13:14 -0500 Message-ID: <87mw3z8ehh.fsf@fsf.org> References: <87sidrll19.fsf@denknerd.org> <87vbin8qo2.fsf@fsf.org> <87lhjj72p3.fsf@netris.org> <87oaofiak5.fsf@denknerd.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46354) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YROTY-0007Yp-Fe for guix-devel@gnu.org; Fri, 27 Feb 2015 12:13:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YROTX-0000th-Ej for guix-devel@gnu.org; Fri, 27 Feb 2015 12:13:20 -0500 Received: from mail.fsf.org ([208.118.235.13]:41241) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YROTX-0000ta-CF for guix-devel@gnu.org; Fri, 27 Feb 2015 12:13:19 -0500 In-Reply-To: <87oaofiak5.fsf@denknerd.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Paul van der Walt , Mark H Weaver Cc: Guix-devel Paul van der Walt writes: > On 2015-02-27 at 17:13, quoth Mark H Weaver: >>> Paul van der Walt writes: >> [...] >>>> + (arguments >>>> + '(#:configure-flags >>>> + '("BOOST_LIB_SUFFIX=") >>>> + #:phases >>>> + (alist-cons-after >>>> + 'unpack 'autogen >>>> + (lambda _ >>>> + (substitute* "autogen.sh" >>>> + (("/bin/sh") (which "bash"))) >>> >>> Is "autogen.sh" not executable? If it starts with a shebang, Guix >>> should patch the file appropriately. >> >> The problem here is that this 'autogen' phase is run before the >> 'patch-source-shebangs' phase, at my suggestion. It has to be that way, >> because 'patch-source-shebangs' (and 'patch-usr-bin-file') will need to >> be run on the files created by 'autogen.sh'. > > This is the case. Is this therefore the cleanest way to do it? Yes. >> Could you please add a copyright line for yourself at the top of this >> file? > > Are these from lines not enough? My previous patch which i generated the > same way was accepted. Each source code file has copyright information at the very top for each person that has contributed code to that file. Follow the pattern of the other contributor(s) and add your information. Adding copyright information is not necessary for trivial changes, but you've definitely made non-trivial changes here. Thanks! -- David Thompson Web Developer - Free Software Foundation - http://fsf.org GPG Key: 0FF1D807 Support the FSF: https://fsf.org/donate