Re: [PATCH] Update ncmpcpp to v0.6.2

[David Thompson <dthompson2@worcester.edu>]

Paul van der Walt <paul@denknerd.org> writes:

> On 2015-02-27 at 17:13, quoth Mark H Weaver:
>>> Paul van der Walt <paul@denknerd.org> writes:
>> [...]
>>>> +    (arguments
>>>> +     '(#:configure-flags
>>>> +       '("BOOST_LIB_SUFFIX=")
>>>> +       #:phases
>>>> +       (alist-cons-after
>>>> +        'unpack 'autogen
>>>> +        (lambda _
>>>> +          (substitute* "autogen.sh"
>>>> +            (("/bin/sh") (which "bash")))
>>>
>>> Is "autogen.sh" not executable?  If it starts with a shebang, Guix
>>> should patch the file appropriately.
>>
>> The problem here is that this 'autogen' phase is run before the
>> 'patch-source-shebangs' phase, at my suggestion.  It has to be that way,
>> because 'patch-source-shebangs' (and 'patch-usr-bin-file') will need to
>> be run on the files created by 'autogen.sh'.
>
> This is the case. Is this therefore the cleanest way to do it?

Yes.

>> Could you please add a copyright line for yourself at the top of this
>> file?
>
> Are these from lines not enough? My previous patch which i generated the
> same way was accepted.

Each source code file has copyright information at the very top for each
person that has contributed code to that file.  Follow the pattern of
the other contributor(s) and add your information.  Adding copyright
information is not necessary for trivial changes, but you've definitely
made non-trivial changes here.

Thanks!

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate