From: David Thompson <dthompson2@worcester.edu>
To: Paul van der Walt <paul@denknerd.org>, Mark H Weaver <mhw@netris.org>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] Update ncmpcpp to v0.6.2
Date: Fri, 27 Feb 2015 12:13:14 -0500 [thread overview]
Message-ID: <87mw3z8ehh.fsf@fsf.org> (raw)
In-Reply-To: <87oaofiak5.fsf@denknerd.org>
Paul van der Walt <paul@denknerd.org> writes:
> On 2015-02-27 at 17:13, quoth Mark H Weaver:
>>> Paul van der Walt <paul@denknerd.org> writes:
>> [...]
>>>> + (arguments
>>>> + '(#:configure-flags
>>>> + '("BOOST_LIB_SUFFIX=")
>>>> + #:phases
>>>> + (alist-cons-after
>>>> + 'unpack 'autogen
>>>> + (lambda _
>>>> + (substitute* "autogen.sh"
>>>> + (("/bin/sh") (which "bash")))
>>>
>>> Is "autogen.sh" not executable? If it starts with a shebang, Guix
>>> should patch the file appropriately.
>>
>> The problem here is that this 'autogen' phase is run before the
>> 'patch-source-shebangs' phase, at my suggestion. It has to be that way,
>> because 'patch-source-shebangs' (and 'patch-usr-bin-file') will need to
>> be run on the files created by 'autogen.sh'.
>
> This is the case. Is this therefore the cleanest way to do it?
Yes.
>> Could you please add a copyright line for yourself at the top of this
>> file?
>
> Are these from lines not enough? My previous patch which i generated the
> same way was accepted.
Each source code file has copyright information at the very top for each
person that has contributed code to that file. Follow the pattern of
the other contributor(s) and add your information. Adding copyright
information is not necessary for trivial changes, but you've definitely
made non-trivial changes here.
Thanks!
--
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate
next prev parent reply other threads:[~2015-02-27 17:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 10:13 [PATCH] Update ncmpcpp to v0.6.2 Paul van der Walt
2015-02-27 12:50 ` David Thompson
2015-02-27 16:13 ` Mark H Weaver
2015-02-27 16:18 ` David Thompson
2015-02-27 16:27 ` Paul van der Walt
2015-02-27 17:13 ` David Thompson [this message]
2015-02-27 18:21 ` Mark H Weaver
2015-02-27 18:53 ` Paul van der Walt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mw3z8ehh.fsf@fsf.org \
--to=dthompson2@worcester.edu \
--cc=guix-devel@gnu.org \
--cc=mhw@netris.org \
--cc=paul@denknerd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.