From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul van der Walt <paul@denknerd.org>
Subject: Re: [PATCH 4/8] gnu: Add zathura.
Date: Mon, 02 Mar 2015 22:20:43 +0100
Message-ID: <87mw3vjduc.fsf@denknerd.org>
References: <1425290046-9612-1-git-send-email-paul@denknerd.org>
	<1425290046-9612-4-git-send-email-paul@denknerd.org>
	<87zj7vm9t7.fsf@netris.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47321)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1YSXll-0002jD-An
	for guix-devel@gnu.org; Mon, 02 Mar 2015 16:20:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1YSXlf-0002sj-9D
	for guix-devel@gnu.org; Mon, 02 Mar 2015 16:20:53 -0500
Received: from mx02.posteo.de ([89.146.194.165]:58700)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1YSXlf-0002sZ-2p
	for guix-devel@gnu.org; Mon, 02 Mar 2015 16:20:47 -0500
In-reply-to: <87zj7vm9t7.fsf@netris.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org


On 2015-03-02 at 21:19, quoth Mark H Weaver:
> It's not important, but the way we usually write this is:
> [...]
> We don't generally describe what new files are for in the commit log.
> Such explanations belong in the files themselves.

Will fix!

> For consistency, please use tabs before the "\", and keep the blank line
> above the MISC_DISTRO_FILES definition.

Done.

> Since the environment variable can hold a path with more than one
> directory, it is misnamed.  How about ZATHURA_PLUGIN_PATH instead?
>
> Also the code above could be simplified.
> How about something like this: (untested)

That looks quite elegant, will try it. Thanks for the suggestion!

>     dir = g_getenv("ZATHURA_PLUGIN_PATH");
>
> What do you think?

Using your name and approach :)

> Probably the description should start with a capital letter, and I would
> remove "and functional" and "as well as an easy usage" which sound like
> marketing-speak.

True.

> Please move this next to 'native-inputs'.

I'll neaten them all up a bit.

Expect a pile of patches promptly.

Thanks,
p.