Re: Problem with patching tar

[ludo@gnu.org (Ludovic Courtès)]

[-- Attachment #1: Type: text/plain, Size: 544 bytes --]

Manolis Ragkousis <manolis837@gmail.com> skribis:

> When I try to patch tar I get "(vm-run "VM: Stack overflow" ())",
> probably, because it tries to use patch but it does not yet exist and
> I get the chicken-egg problem.

Indeed.  The problem was that, by default, source patching in
‘patch-and-repack’ would use not the tar from ‘%final-inputs’, but the
tar built with ‘%final-inputs’.  Hence the circular dependency: to apply
the patch of this tar, we would first need to built it.

So you first need this patch:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1204 bytes --]

--- a/guix/packages.scm
+++ b/guix/packages.scm
@@ -315,8 +315,11 @@ representation."
   (string-append (package-name package) "-" (package-version package)))
 
 (define (%standard-patch-inputs)
-  (let ((ref (lambda (module var)
-               (module-ref (resolve-interface module) var))))
+  (let* ((canonical (module-ref (resolve-interface '(gnu packages base))
+                                'canonical-package))
+         (ref       (lambda (module var)
+                      (canonical
+                       (module-ref (resolve-interface module) var)))))
     `(("tar"   ,(ref '(gnu packages base) 'tar))
       ("xz"    ,(ref '(gnu packages compression) 'xz))
       ("bzip2" ,(ref '(gnu packages compression) 'bzip2))
@@ -324,8 +327,7 @@ representation."
       ("lzip"  ,(ref '(gnu packages compression) 'lzip))
       ("unzip" ,(ref '(gnu packages zip) 'unzip))
       ("patch" ,(ref '(gnu packages base) 'patch))
-      ("locales" ,(ref '(gnu packages commencement)
-                       'glibc-utf8-locales-final)))))
+      ("locales" ,(ref '(gnu packages base) 'glibc-utf8-locales)))))
 
 (define (default-guile)
   "Return the default Guile package used to run the build code of

[-- Attachment #3: Type: text/plain, Size: 126 bytes --]


I just pushed it to wip-hurd.

Make sure to remind us to apply it in the next core-updates cycle.

Thanks!

Ludo’.