Taylan Ulrich Bayırlı/Kammer writes:

> Christopher Allan Webber <cwebber@dustycloud.org> writes:
>
>> +    (native-inputs
>> +     `(("autoconf" ,autoconf)
>> +       ("automake" ,automake)
>> +       ,@(package-native-inputs emacs)))
>> +    (inputs
>> +     `(("guile" ,guile-for-guile-emacs)
>> +       ,@(package-inputs emacs)))
>
> I didn't think about this before: if Guile is used at compile-time,
> e.g. to compile any .scm or .el files, then it should be in native
> inputs too.  Can you verify whether it's used or not?  (In the future it
> probably will be used to compile .el files, but that's still not enabled
> if I remember correctly.)

It is, moved it.

>> +    (arguments
>> +     (substitute-keyword-arguments `(;; Build fails if we allow parallel build
>> +                                     #:parallel-build? #f
>
> Stylistic nitpick: sentence in comment should end with a period.

Ok

>> +    (native-inputs
>> +     `(("autoconf" ,autoconf)
>> +       ("automake" ,automake)
>> +       ("libtool" ,libtool)
>> +       ("flex" ,flex)
>> +       ("texinfo" ,texinfo)
>> +       ,@(package-native-inputs guile-2.0)))
>> +    (inputs
>> +     `(("gettext" ,gnu-gettext)
>> +       ,@(package-inputs guile-2.0)))))
>
> I think we wanted to put Gettext in native-inputs?

Done

>
> I'd say OK to push with those changes, thanks! :-)
>
> Taylan

Great, I hope it's good now!