From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Mickey Subject: Re: [PATCH] gnu: add the rc shell package Date: Sat, 11 Jul 2015 17:57:00 -0700 Message-ID: <87mvz2b3c3.fsf@codemac.net> References: <871tggddtr.fsf@codemac.net> <87d1zz5lbn.fsf@netris.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60315) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZE5Zr-0000UT-KO for guix-devel@gnu.org; Sat, 11 Jul 2015 20:57:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZE5Zo-0006kf-CZ for guix-devel@gnu.org; Sat, 11 Jul 2015 20:57:07 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:45817) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZE5Zo-0006kO-5B for guix-devel@gnu.org; Sat, 11 Jul 2015 20:57:04 -0400 In-Reply-To: <87d1zz5lbn.fsf@netris.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Mark H Weaver Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain Thank you so much for the kind and prompt feedback folks! Here is my updated patch, let me know if I've addressed your concerns. // codemac --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=0001-gnu-add-the-rc-shell-package.patch Content-Transfer-Encoding: quoted-printable >From 85e9fef8f3eec0b434c909627cd68d5584597aa0 Mon Sep 17 00:00:00 2001 From: Jeff Mickey Date: Thu, 9 Jul 2015 17:39:42 -0700 Subject: [PATCH] gnu: add the rc shell package * gnu/packages/rc.scm: New file. --- gnu/packages/rc.scm | 77 +++++++++++++++++++++++++++++++++++++++++++++++++= ++++ 1 file changed, 77 insertions(+) create mode 100644 gnu/packages/rc.scm diff --git a/gnu/packages/rc.scm b/gnu/packages/rc.scm new file mode 100644 index 0000000..6bd2b51 --- /dev/null +++ b/gnu/packages/rc.scm @@ -0,0 +1,77 @@ +;;; GNU Guix --- Functional package management for GNU +;;; Copyright =C2=A9 2013, 2014, 2015 Ludovic Court=C3=A8s +;;; +;;; This file is part of GNU Guix. +;;; +;;; GNU Guix is free software; you can redistribute it and/or modify it +;;; under the terms of the GNU General Public License as published by +;;; the Free Software Foundation; either version 3 of the License, or (at +;;; your option) any later version. +;;; +;;; GNU Guix is distributed in the hope that it will be useful, but +;;; WITHOUT ANY WARRANTY; without even the implied warranty of +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;;; GNU General Public License for more details. +;;; +;;; You should have received a copy of the GNU General Public License +;;; along with GNU Guix. If not, see . + +(define-module (gnu packages rc) + #:use-module (gnu packages autotools) + #:use-module (gnu packages perl) + #:use-module (gnu packages pkg-config) + #:use-module (gnu packages readline) + #:use-module (guix build gnu-build-system) + #:use-module (guix build utils) + #:use-module (guix build-system gnu) + #:use-module (guix download) + #:use-module (guix git-download) + #:use-module (guix licenses) + #:use-module (guix packages)) + +(define-public rc + (package + (name "rc") + (version "1.7.4") + (source (origin + (method git-fetch) + (uri (git-reference + (url "git://github.com/rakitzis/rc.git") + ;; commit name 'release: rc-1.7.4' + (commit "c884da53a7c885d46ace2b92de78946855b18e92"))) + (sha256 + (base32 + "00mgzvrrh9w96xa85g4gjbsvq02f08k4jwjcdnxq7kyh5xgiw95l")))) + (build-system gnu-build-system) + (arguments + `(#:configure-flags + '("--with-edit=3Dgnu") + #:phases + (modify-phases %standard-phases + (add-before + 'configure 'autoreconf + (lambda _ (zero? (system* "autoreconf" "-vfi")))) + (add-before + 'autoreconf 'rewrite-paths + (lambda _ + (substitute* "trip.rc" + (("/bin/pwd") (which "pwd")) + (("/bin/sh") (which "sh"))))) + ;; this removes a single test which checks that for sure rm is in + ;; /bin/rm + (add-after + 'rewrite-paths 'patch-triprc + (lambda _ (zero? (system* "sed" "-i" "282,284d" "trip.rc"))))) + #:tests? #t)) ;; trip.rc explicity tests for /bin + (inputs `(("readline" ,readline) + ("perl" ,perl))) + (native-inputs `(("autoconf" ,autoconf) + ("automake" ,automake) + ("libtool" ,libtool) + ("pkg-config" ,pkg-config))) + (synopsis "An alternative implementation of the plan 9 rc shell.") + (description + "This is a reimplementation for Unix, by Byron Rakitzis, of the Plan 9 +shell. It has a small feature set similar to a traditional Bourne shell.") + (home-page "http://github.com/rakitzis/rc") + (license zlib))) --=20 2.4.5 --=-=-=--