* [PATCH 1/2] gnu: Add ruby-docile.
@ 2015-09-16 4:06 Pjotr Prins
2015-09-16 9:39 ` Ricardo Wurmus
2015-09-19 12:37 ` Thompson, David
0 siblings, 2 replies; 4+ messages in thread
From: Pjotr Prins @ 2015-09-16 4:06 UTC (permalink / raw)
To: guix-devel
* gnu/packages/ruby.scm (ruby-docile): New variable.
---
gnu/packages/ruby.scm | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 7dc46b6..539b00b 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -1125,6 +1125,28 @@ into a single method call.")
(home-page "http://rack.github.io/")
(license license:expat)))
+(define-public ruby-docile
+ (package
+ (name "ruby-docile")
+ (version "1.1.5")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (rubygems-uri "docile" version))
+ (sha256
+ (base32
+ "0m8j31whq7bm5ljgmsrlfkiqvacrw6iz9wq10r3gwrv5785y8gjx"))))
+ (build-system ruby-build-system)
+ (arguments
+ '(#:tests? #f)) ; needs github-markup, among others
+ (synopsis "Docile turns any Ruby object into a DSL")
+ (description "Turn any Ruby object into a DSL. Especially useful
+with the Builder pattern. Docile is a small, self-contained Ruby
+library, that let's you map a DSL (domain specific language) to your
+Ruby objects in a snap.")
+ (home-page "https://ms-ati.github.io/docile/")
+ (license license:expat)))
+
(define-public ruby-gherkin3
(package
(name "ruby-gherkin3")
@@ -1147,3 +1169,4 @@ It is intended to replace Gherkin 2 and be used by all Cucumber
implementations to parse '.feature' files.")
(home-page "https://github.com/cucumber/gherkin3")
(license license:expat)))
+
--
2.4.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] gnu: Add ruby-docile.
2015-09-16 4:06 [PATCH 1/2] gnu: Add ruby-docile Pjotr Prins
@ 2015-09-16 9:39 ` Ricardo Wurmus
2015-09-17 5:19 ` Pjotr Prins
2015-09-19 12:37 ` Thompson, David
1 sibling, 1 reply; 4+ messages in thread
From: Ricardo Wurmus @ 2015-09-16 9:39 UTC (permalink / raw)
To: Pjotr Prins; +Cc: guix-devel
Hi Pjotr,
> * gnu/packages/ruby.scm (ruby-docile): New variable.
[...]
> + (arguments
> + '(#:tests? #f)) ; needs github-markup, among others
There also is at least one nasty dependency cycle which should be
mentioned. A development dependency is ruby-coveralls, which needs
ruby-simplecov at runtime, which in turn needs ruby-docile at runtime.
Other dev dependencies are ruby-github-markdown, ruby-redcarpet, and
ruby-rspec. (I’ve been working on the same package but went down the
rabbit hole, depth first.)
> + (synopsis "Docile turns any Ruby object into a DSL")
> + (description "Turn any Ruby object into a DSL. Especially useful
> +with the Builder pattern. Docile is a small, self-contained Ruby
> +library, that let's you map a DSL (domain specific language) to your
> +Ruby objects in a snap.")
This description is not very helpful, probably because the first two
sentences are just fragments. The last sentence is okay, except for the
“in a snap”, IMO.
> + (home-page "https://ms-ati.github.io/docile/")
> + (license license:expat)))
> +
> (define-public ruby-gherkin3
> (package
> (name "ruby-gherkin3")
> @@ -1147,3 +1169,4 @@ It is intended to replace Gherkin 2 and be used by all Cucumber
> implementations to parse '.feature' files.")
> (home-page "https://github.com/cucumber/gherkin3")
> (license license:expat)))
> +
Oh, an additional newline in the middle of “ruby-gherkin3”? Did
something go wrong when cutting out the patch amidst other changes?
~~ Ricardo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] gnu: Add ruby-docile.
2015-09-16 9:39 ` Ricardo Wurmus
@ 2015-09-17 5:19 ` Pjotr Prins
0 siblings, 0 replies; 4+ messages in thread
From: Pjotr Prins @ 2015-09-17 5:19 UTC (permalink / raw)
To: Ricardo Wurmus; +Cc: guix-devel
Do you mind just editing this patch your way? The description comes
from the package website - I don't feel the urge to improve on it.
Pj.
On Wed, Sep 16, 2015 at 11:39:38AM +0200, Ricardo Wurmus wrote:
> Hi Pjotr,
>
> > * gnu/packages/ruby.scm (ruby-docile): New variable.
>
> [...]
>
> > + (arguments
> > + '(#:tests? #f)) ; needs github-markup, among others
>
> There also is at least one nasty dependency cycle which should be
> mentioned. A development dependency is ruby-coveralls, which needs
> ruby-simplecov at runtime, which in turn needs ruby-docile at runtime.
>
> Other dev dependencies are ruby-github-markdown, ruby-redcarpet, and
> ruby-rspec. (I’ve been working on the same package but went down the
> rabbit hole, depth first.)
>
> > + (synopsis "Docile turns any Ruby object into a DSL")
> > + (description "Turn any Ruby object into a DSL. Especially useful
> > +with the Builder pattern. Docile is a small, self-contained Ruby
> > +library, that let's you map a DSL (domain specific language) to your
> > +Ruby objects in a snap.")
>
> This description is not very helpful, probably because the first two
> sentences are just fragments. The last sentence is okay, except for the
> “in a snap”, IMO.
>
> > + (home-page "https://ms-ati.github.io/docile/")
> > + (license license:expat)))
> > +
> > (define-public ruby-gherkin3
> > (package
> > (name "ruby-gherkin3")
> > @@ -1147,3 +1169,4 @@ It is intended to replace Gherkin 2 and be used by all Cucumber
> > implementations to parse '.feature' files.")
> > (home-page "https://github.com/cucumber/gherkin3")
> > (license license:expat)))
> > +
>
> Oh, an additional newline in the middle of “ruby-gherkin3”? Did
> something go wrong when cutting out the patch amidst other changes?
>
> ~~ Ricardo
>
--
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] gnu: Add ruby-docile.
2015-09-16 4:06 [PATCH 1/2] gnu: Add ruby-docile Pjotr Prins
2015-09-16 9:39 ` Ricardo Wurmus
@ 2015-09-19 12:37 ` Thompson, David
1 sibling, 0 replies; 4+ messages in thread
From: Thompson, David @ 2015-09-19 12:37 UTC (permalink / raw)
To: Pjotr Prins; +Cc: guix-devel
On Wed, Sep 16, 2015 at 12:06 AM, Pjotr Prins <pjotr.public12@thebird.nl> wrote:
> * gnu/packages/ruby.scm (ruby-docile): New variable.
> ---
> gnu/packages/ruby.scm | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
> index 7dc46b6..539b00b 100644
> --- a/gnu/packages/ruby.scm
> +++ b/gnu/packages/ruby.scm
> @@ -1125,6 +1125,28 @@ into a single method call.")
> (home-page "http://rack.github.io/")
> (license license:expat)))
>
> +(define-public ruby-docile
> + (package
> + (name "ruby-docile")
> + (version "1.1.5")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (rubygems-uri "docile" version))
> + (sha256
> + (base32
> + "0m8j31whq7bm5ljgmsrlfkiqvacrw6iz9wq10r3gwrv5785y8gjx"))))
> + (build-system ruby-build-system)
> + (arguments
> + '(#:tests? #f)) ; needs github-markup, among others
> + (synopsis "Docile turns any Ruby object into a DSL")
> + (description "Turn any Ruby object into a DSL. Especially useful
> +with the Builder pattern. Docile is a small, self-contained Ruby
> +library, that let's you map a DSL (domain specific language) to your
> +Ruby objects in a snap.")
A lot of times, the upstream description of software reads like an
advertisement or doesn't well define their terms, so we need to come
up with an appropriate description ourselves. I changed the synopsis
and description as follows:
(synopsis "Ruby EDSL helper library")
(description "Docile is a Ruby library that provides an interface for
creating embedded domain specific languages (EDSLs) that manipulate existing
Ruby classes.")
> + (home-page "https://ms-ati.github.io/docile/")
> + (license license:expat)))
> +
> (define-public ruby-gherkin3
> (package
> (name "ruby-gherkin3")
> @@ -1147,3 +1169,4 @@ It is intended to replace Gherkin 2 and be used by all Cucumber
> implementations to parse '.feature' files.")
> (home-page "https://github.com/cucumber/gherkin3")
> (license license:expat)))
> +
I removed this extraneous whitespace change.
> --
> 2.4.3
>
>
Pushed. Thanks.
- Dave
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-09-19 12:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-16 4:06 [PATCH 1/2] gnu: Add ruby-docile Pjotr Prins
2015-09-16 9:39 ` Ricardo Wurmus
2015-09-17 5:19 ` Pjotr Prins
2015-09-19 12:37 ` Thompson, David
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.