From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 1/1] gnu: openexr: Disable broken test to fix build on i686. Date: Fri, 11 Mar 2016 15:41:49 +0100 Message-ID: <87mvq5yt3m.fsf@gnu.org> References: <8c8bd1a93437ee981f97979b7cd029800a746a03.1457640278.git.leo@famulari.name> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41500) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aeOGL-0005dR-0g for guix-devel@gnu.org; Fri, 11 Mar 2016 09:41:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aeOGG-0007Zj-8a for guix-devel@gnu.org; Fri, 11 Mar 2016 09:41:56 -0500 In-Reply-To: <8c8bd1a93437ee981f97979b7cd029800a746a03.1457640278.git.leo@famulari.name> (Leo Famulari's message of "Thu, 10 Mar 2016 15:12:27 -0500") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Leo Famulari Cc: guix-devel@gnu.org Leo Famulari skribis: > * gnu/packages/graphics.scm (openexr)[arguments]: New field. > --- > gnu/packages/graphics.scm | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/gnu/packages/graphics.scm b/gnu/packages/graphics.scm > index c022d74..3c5ad72 100644 > --- a/gnu/packages/graphics.scm > +++ b/gnu/packages/graphics.scm > @@ -206,6 +206,20 @@ exception-handling library.") > "\"/tmp/\""))) > (patches (list (search-patch "openexr-missing-samples.patc= h"))))) > (build-system gnu-build-system) > + (arguments > + '(#:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'disable-broken-test > + ;; This test fails on i686. Upstream developers suggest that > + ;; this test is broken on i686 and can be safely disabled: > + ;; https://github.com/openexr/openexr/issues/67#issuecomment-21= 169748 > + (lambda _ Better to indent the comment with =E2=80=9C(lambda=E2=80=9D below. Otherwise LGTM, thanks for fixing this! Ludo=E2=80=99.