From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH 5/6] gnu: Add borg. Date: Tue, 22 Mar 2016 23:20:37 +0300 Message-ID: <87mvpqtgbu.fsf@gmail.com> References: <14fe75ec9c8b651be6a5240dd5444e558615e1e1.1457998381.git.leo@famulari.name> <878u1k2jik.fsf@gmail.com> <20160315091845.GA9602@jasmine> <20160321213115.GA2717@jasmine> <20160321223519.GA6523@jasmine> <20160321225259.GA7558@jasmine> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55487) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiSnF-0006j3-NA for guix-devel@gnu.org; Tue, 22 Mar 2016 16:20:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aiSnA-00028L-Mg for guix-devel@gnu.org; Tue, 22 Mar 2016 16:20:45 -0400 Received: from mail-lf0-x242.google.com ([2a00:1450:4010:c07::242]:35735) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiSnA-00027N-1E for guix-devel@gnu.org; Tue, 22 Mar 2016 16:20:40 -0400 Received: by mail-lf0-x242.google.com with SMTP id g73so4979255lfg.2 for ; Tue, 22 Mar 2016 13:20:39 -0700 (PDT) In-Reply-To: <20160321225259.GA7558@jasmine> (Leo Famulari's message of "Mon, 21 Mar 2016 18:52:59 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Leo Famulari Cc: guix-devel@gnu.org Leo Famulari (2016-03-22 01:52 +0300) wrote: > On Mon, Mar 21, 2016 at 06:35:19PM -0400, Leo Famulari wrote: >> I asked upstream about some warnings during the docs generation, and >> they pointed out that I needed to add a command line. I've attached a >> revised patch. >> >> Can I get some feedback on it? > > Based on feedback on #guix, I've revised it again. Attached... > From: Leo Famulari > Date: Mon, 14 Mar 2016 19:34:25 -0400 > Subject: [PATCH 5/6] gnu: Add borg. > > * gnu/packages/backup.scm (borg): New variable. [...] > +(define-public borg > + (package > + (name "borg") > + (version "1.0.0") > + (source (origin > + (method url-fetch) > + (uri (pypi-uri "borgbackup" version)) > + (sha256 > + (base32 > + "0wa6cvqs3rni5nwrgagigchcly8a53rxk56z0zn8iaii2cqrw2sh")))) > + (build-system python-build-system) > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'set-env > + (lambda* (#:key inputs #:allow-other-keys) > + (let ((openssl (assoc-ref inputs "openssl")) > + (lz4 (assoc-ref inputs "lz4"))) > + (setenv "BORG_OPENSSL_PREFIX" openssl) > + (setenv "BORG_LZ4_PREFIX" lz4) > + (setenv "PYTHON_EGG_CACHE" "/tmp") > + #t))) If you keep #t inside 'let', then align it to (setenv ...), or move it away from 'let': (lambda* (#:key inputs #:allow-other-keys) (let ((openssl (assoc-ref inputs "openssl")) (lz4 (assoc-ref inputs "lz4"))) (setenv "BORG_OPENSSL_PREFIX" openssl) (setenv "BORG_LZ4_PREFIX" lz4) (setenv "PYTHON_EGG_CACHE" "/tmp")) #t) Note the difference: another ')' after the last (setenv ...). > + (add-after 'install 'docs Perhaps it is better to call this phase 'install-doc'. It's a usual name that can be met in other recipes. There is also 'install-man-pages' phase name, but I prefer 'install-doc'. The rest looks good to me, so if you checked that this program works, I think you can push this patchset. -- Alex