From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andy Wingo <wingo@igalia.com>
Subject: Re: [PATCH 08/10] gnu: readline: support mingw.
Date: Mon, 02 May 2016 10:12:33 +0200
Message-ID: <87mvo8naj2.fsf@igalia.com>
References: <1461942751-23883-1-git-send-email-janneke@gnu.org>
	<1461942751-23883-8-git-send-email-janneke@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41795)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wingo@igalia.com>) id 1ax8yU-00079v-CN
	for guix-devel@gnu.org; Mon, 02 May 2016 04:13:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <wingo@igalia.com>) id 1ax8yI-0003NB-QA
	for guix-devel@gnu.org; Mon, 02 May 2016 04:12:56 -0400
In-Reply-To: <1461942751-23883-8-git-send-email-janneke@gnu.org> (Jan
	Nieuwenhuizen's message of "Fri, 29 Apr 2016 17:12:29 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Jan Nieuwenhuizen <janneke@gnu.org>
Cc: guix-devel@gnu.org

On Fri 29 Apr 2016 17:12, Jan Nieuwenhuizen <janneke@gnu.org> writes:

> * gnu/packages/patches/readline-6.3-mingw.patch: New file.
> * gnu-system.am (dist_patch_DATA): Add it.
> * gnu/packages/readline.scm (readline): Support mingw.

Can you clarify the licensing on the patch, and note its original
author?  Ideally we should send the patch upstream, too.

>        (arguments `(#:configure-flags
>                     (list (string-append "LDFLAGS=-Wl,-rpath -Wl,"
>                                          (assoc-ref %build-inputs "ncurses")
> -                                        "/lib")
> +                                        ,(if (mingw-target?) "/bin" "/lib"))

Is there a reason for MinGW ncurses to put its library in /bin on a
MinGW system?  Better if it put it in /lib like everything else...

Andy