From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 0/2] Add emacs-emms-player-mpv. Date: Wed, 29 Jun 2016 15:09:53 +0200 Message-ID: <87mvm487ku.fsf@gnu.org> References: <20160629054549.6433-1-rekado@elephly.net> <87lh1ofjvh.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41773) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bIFFk-0002hd-6V for guix-devel@gnu.org; Wed, 29 Jun 2016 09:10:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bIFFe-0006OU-2J for guix-devel@gnu.org; Wed, 29 Jun 2016 09:10:03 -0400 In-Reply-To: <87lh1ofjvh.fsf@gmail.com> (Alex Kost's message of "Wed, 29 Jun 2016 12:02:26 +0300") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Alex Kost Cc: guix-devel@gnu.org Alex Kost skribis: > Ricardo Wurmus (2016-06-29 08:45 +0300) wrote: > >> Hi Guix, >> >> I think we need to rename the =E2=80=9Cemms=E2=80=9D package to =E2=80= =9Cemacs-emms=E2=80=9D. (This is what >> the first patch does.) Currently, the emacs-build-system will only add = to the >> Emacs =E2=80=9Cload-path=E2=80=9D the =E2=80=9Csite-lisp=E2=80=9D direct= ories of packages that start with >> =E2=80=9Cemacs-=E2=80=9D. I think it may be necessary to relax this req= uirement for cases in >> which a non-Emacs package provides an Emacs mode. > > I agree! I also think this check for "emacs-" is not needed. > >> In the case of =E2=80=9Cemms=E2=80=9D, >> however, I think renaming it is justified. > > I agree, but note that there was a discussion about renaming all emacs > packages (geiser, magit, etc.) and making alisases for the old names: > A year later, it still looks like a good idea. :-) Damn it, we should do something about it. >> The second patch adds an EMMS player. The byte-compilation phase only >> succeeds after renaming =E2=80=9Cemms=E2=80=9D, because otherwise it wou= ldn=E2=80=99t find the lisp >> files provides by that package. >> >> Ricardo Wurmus (2): >> gnu: emms: Rename package to "emacs-emms". >> gnu: Add emacs-emms-player-mpv. > > Both patches look good to me, but I would wait for other comments about > renaming as it is not very backward compatible :-) A mass rename would cause users a lot of pain, but a single package is OK, IMO. (Don=E2=80=99t tell me you want to do a mass rename at a one rename/week rate! ;-)) Thoughts? Ludo=E2=80=99.