From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH v2] gnu: Add lrzip. Date: Fri, 22 Jul 2016 15:13:06 +0200 Message-ID: <87mvl9q0il.fsf@gnu.org> References: <20160721202430.31332-1-me@tobias.gr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58367) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQaGT-0007tj-Rw for guix-devel@gnu.org; Fri, 22 Jul 2016 09:13:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQaGR-0004kj-VS for guix-devel@gnu.org; Fri, 22 Jul 2016 09:13:16 -0400 In-Reply-To: (Tobias Geerinckx-Rice's message of "Thu, 21 Jul 2016 22:31:55 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Tobias Geerinckx-Rice Cc: guix-devel@gnu.org, Guix-devel Hi Tobias, Tobias Geerinckx-Rice skribis: > On 2016-07-21 22:24, Tobias Geerinckx-Rice wrote: >> + (native-inputs >> + `(,@(if (string-prefix? "i686" (or (%current-target-system) >> + (%current-system))) >> + `(("nasm" ,nasm)) >> + '()) > > Hmm. Not sure where this falls on the =E2=80=98let the code speak for its= elf=E2=80=99 > to =E2=80=98should have added a comment=E2=80=99 scale. > > Guess I'll wait for another review + patch or a very friendly committer. I have another idea: could you create a Savannah account and tell me your user name? :-) Thanks, Ludo=E2=80=99.