From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Kost <alezost@gmail.com>
Subject: Re: [PATCH 10/24] gnu: networkmanager-qt: Propagate network-manager.
Date: Tue, 16 Aug 2016 23:07:17 +0300
Message-ID: <87mvkciikq.fsf@gmail.com>
References: <20160816183938.22794-1-david@craven.ch>
	<20160816183938.22794-10-david@craven.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44653)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1bZkdv-0006GZ-DA
	for guix-devel@gnu.org; Tue, 16 Aug 2016 16:07:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1bZkdq-0001K9-Cg
	for guix-devel@gnu.org; Tue, 16 Aug 2016 16:07:23 -0400
Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:33578)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1bZkdq-0001K2-5O
	for guix-devel@gnu.org; Tue, 16 Aug 2016 16:07:18 -0400
Received: by mail-wm0-x242.google.com with SMTP id o80so18258018wme.0
	for <guix-devel@gnu.org>; Tue, 16 Aug 2016 13:07:18 -0700 (PDT)
In-Reply-To: <20160816183938.22794-10-david@craven.ch> (David Craven's message
	of "Tue, 16 Aug 2016 20:39:24 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org

David Craven (2016-08-16 21:39 +0300) wrote:

> * gnu/packages/kde-frameworks.scm (networkmanager-qt)
>   [propagated-inputs]: Add NETWORK-MANAGER.
>   [inputs]: Remove NETWORK-MANAGER.

I would write 'network-manager' instead of NETWORK-MANAGER.

Also there should be a reason for propagating (probably written as a
comment).  Ideally it should be avoided.

> ---
>  gnu/packages/kde-frameworks.scm | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
>
> diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-framework=
s.scm
> index dbec5a3..61ed4aa 100644
> --- a/gnu/packages/kde-frameworks.scm
> +++ b/gnu/packages/kde-frameworks.scm
> @@ -934,9 +934,10 @@ messages.")
>        `(("extra-cmake-modules" ,extra-cmake-modules)
>          ("dbus" ,dbus)
>          ("pkg-config" ,pkg-config)))
> +     (propagated-inputs
> +      `(("network-manager", network-manager)))
                             =E2=86=91=E2=86=91
BTW please fix the comma placement here:
                             =E2=86=93=E2=86=93
         `(("network-manager" ,network-manager)))

>       (inputs
> -      `(("network-manager", network-manager)
> -        ("qtbase" ,qtbase)))
> +      `(("qtbase" ,qtbase)))
>       (arguments
>        `(#:phases
>           (modify-phases %standard-phases

--=20
Alex