From: Christopher Allan Webber <cwebber@dustycloud.org>
To: ng0 <ngillmann@runbox.com>
Cc: guix-devel@gnu.org, Alex Kost <alezost@gmail.com>
Subject: Re: Cosmetical change: remove inconsistent "$file ends here"?
Date: Mon, 26 Sep 2016 03:32:24 -0500 [thread overview]
Message-ID: <87mviv12p3.fsf@dustycloud.org> (raw)
In-Reply-To: <87zimws5b1.fsf@we.make.ritual.n0.is>
ng0 writes:
> Alex Kost <alezost@gmail.com> writes:
>
>> ng0 (2016-09-24 20:00 +0000) wrote:
>>
>>> We should either be consistent with this in all files or remove this
>>> altogether in my opinion.
>>>
>>>> ng0@shadowwalker ~/src/guix/guix-no-changes$ egrep -nr "ends here"
>>>> gnu/build/vm.scm:323:;;; vm.scm ends here
>> ...
>>> What do you think?
>>
>> I don't know what the original purpose of this convention is, it was
>> probably invented in those ancient times when dinosaurs walked by
>> streets, but I kinda like these "ends here" things :-)
>>
>> The only purpose I see in using them: you can be sure that there will
>> not appear redundant newlines (introduced by untidy commits) in the end
>> of files.
>>
>> Anyway, I vote for leaving them and adding the missing ones.
>
> Okay, with your explanation this is the more reasonable thing to do.
I'm really fine either way, but that doesn't feel like a super
compelling reason to me. Who cares if there's a redundant newline at
the end of the file? Sure, it should be swept up, but one redundant
newline costs a lot less than "don't let any newlines after this".
Plus, do we have proof that no newlines will really appear afterwards?
It feels like cruft that nobody knows the reason for, or has a good
reason in this modern age. I'd rather they just be trimmed.
But I also don't feel like it matters much, so whatever is decided is
decided. :)
next prev parent reply other threads:[~2016-09-26 8:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-24 20:00 Cosmetical change: remove inconsistent "$file ends here"? ng0
2016-09-25 8:30 ` Alex Kost
2016-09-25 9:21 ` ng0
2016-09-26 8:32 ` Christopher Allan Webber [this message]
2016-09-26 8:45 ` Andy Wingo
2016-09-25 9:32 ` John Darrington
2016-09-25 9:38 ` Danny Milosavljevic
2016-09-25 17:45 ` Hartmut Goebel
2016-09-25 17:55 ` Vincent Legoll
2016-09-25 17:59 ` John Darrington
2016-09-28 8:38 ` Ludovic Courtès
2016-10-06 19:18 ` ng0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mviv12p3.fsf@dustycloud.org \
--to=cwebber@dustycloud.org \
--cc=alezost@gmail.com \
--cc=guix-devel@gnu.org \
--cc=ngillmann@runbox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.