From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kei Kebreau Subject: Re: [PATCH] gnu: Add libjxr. Date: Sat, 29 Oct 2016 00:46:29 -0400 Message-ID: <87mvhn4va2.fsf@openmailbox.org> References: <87eg39qvjh.fsf@openmailbox.org> <20161021235859.GA9570@jasmine> <87a8dwrdf5.fsf@openmailbox.org> <20161023212929.GB6318@jasmine> <87bmy4bni6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:32881) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c0LXn-0003Eo-Ap for guix-devel@gnu.org; Sat, 29 Oct 2016 00:47:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c0LXj-0005HD-Fa for guix-devel@gnu.org; Sat, 29 Oct 2016 00:46:59 -0400 Received: from smtp6.openmailbox.org ([62.4.1.40]:42327) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c0LXj-0005Gm-7A for guix-devel@gnu.org; Sat, 29 Oct 2016 00:46:55 -0400 In-Reply-To: <87bmy4bni6.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Fri, 28 Oct 2016 15:40:17 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Leo Famulari skribis: > >> On Sat, Oct 22, 2016 at 04:33:18AM -0400, Kei Kebreau wrote: > > [...] > >>> >> diff --git a/gnu/packages/patches/libjxr-use-cmake.patch >>> >> b/gnu/packages/patches/libjxr-use-cmake.patch >>> >> new file mode 100644 >>> >> index 0000000..cb5919e >>> >> --- /dev/null >>> >> +++ b/gnu/packages/patches/libjxr-use-cmake.patch >>> >> @@ -0,0 +1,143 @@ >>> >> +Description: Prefer a cmake based build system >>> >> +Author: Mathieu Malaterre >>> >> +Forwarded: https://jxrlib.codeplex.com/discussions/440294 >>> > >>> > Why doesn't upstream's build system work? >>>=20 >>> Upstream's build system simply doesn't have configuration or >>> installation targets in the provided Makefile. Using the cmake patch >>> makes the definition cleaner at the cost of relying on outside work >>> [1]. If this is not acceptable, I can see about writing manual >>> replacement phases to the best of my ability. >>>=20 >>> [1]: https://jxrlib.codeplex.com/discussions/440294 >> >> Hm, not an ideal situation. >> >> If Debian is using this patch, we should link to it's source on Debian's >> site instead of this message board. I don't know enough about CMake to >> judge the patch but I'd be more comfortable if Debian was using it. >> >> What do others think? > > Regarding the choice between writing our own installation phase in > Scheme and using this CMake thing instead, I think we should choose the > most concise approach (in terms of lines of code). > > If the winner here is the CMake patch, then indeed, we should take the > patch from Debian rather than from a message board (and include > provenance information in the patch, as you wrote.) > > That said, I suspect an =E2=80=98install=E2=80=99 phase in Scheme would b= e more concise > than this new CMakeLists.txt (134 lines). > > Kei: WDYT? > I have been working on writing our own installation phase, and it looks like it will be more concise. However, the patches need to be in DOS format to apply. The patch doesn't seem to carry these line returns, which leads me to believe that a standard git configuration won't accept them. Is there way around this? > Thanks! > > Ludo=E2=80=99. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYFCmlAAoJEOal7jwZRnoNGgYQAIU1hu2qtXFp5CpZI+v71dlC OqOjGXneFJbPlfSVizR41OyFfxt0bfnlPTtCOb+VhB/P64fUiNTyF8Sho4EMNXfN AgASfjX0EB8KgjlCOF1D554FvFQgIyGU6Es77KAC4EME5PUGquse1TxaC8xFpqjB /t9urORSkaAXX9ukkYEuZ8PIlUoE7WN8cUQbj7ilwOs30YR3c9uFvnerA6jceTmA AyM8tNqyghX8iLwQhb+lLZehkRbVWcm1JylWS3tW1P9YrtaT7gf4OAjkPtURJIp1 FRFGtZuMs0JBD9+NnTbj3I7XM+VO+itr1tNGWVnnlSvemPCH40DwEBI7xaXhSnQg RA34VQWdKzYpFWTIi7IYqWQ6SMnQJM0DaXWy4DNGTLikxyA94EkWpDZeC4Higf/p BWbZKQuMnUP7Fuvr8rXJQeTiAIHH0HSCYklDR3Pan1a3NGLpmIjlEBkgM6jXIc45 qx0J3+HudvXAMPDyieQuYcXIddYbrG7WVDMoyw90KNx1wmDbKT2mz5/IY8MdywYt Djr6jjzlp3/su1KlFrgSor2WWjLuNCgYPgUQfLOJ+ox9aIRwmjoWVDOvu5wtXjn6 Qx3XxUV+lLx7+oYuPucdvVB0sRUepFM0m6SwQYHSyPFzvC5SoPJBclrWgXRqG+Wu lHK0UwDcAdt/qAPb1xMt =BRyq -----END PGP SIGNATURE----- --=-=-=--