From: ng0 <ng0@libertad.pw>
To: Leo Famulari <leo@famulari.name>, Christopher Baines <mail@cbaines.net>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 3/3] gnu: Add paprefs
Date: Tue, 20 Dec 2016 15:35:07 +0000 [thread overview]
Message-ID: <87mvfqwr4k.fsf@wasp.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <87oa37cb1d.fsf@we.make.ritual.n0.is>
ng0 <niasterisk@grrlz.net> writes:
> I found neither paprefs nor gconfmm in our package database as I was
> about to move this to my 'done' tag, out of sight.
> Can someone (Christopher? Leo?) finish this?
As I got no reply after my initial question, I will fix both of
these packages up next month.
> Thanks.
> Leo Famulari <leo@famulari.name> writes:
>
>> On Wed, Feb 17, 2016 at 03:02:41PM +0000, Christopher Baines wrote:
>>> * gnu/packages/pulseaudio.scm (paprefs): New variable
>>
>> Cool, thanks for the patches! This review is rather superficial since I
>> don't have a GuixSD desktop system, so I can't really test the
>> functionality of the software provided by this patch series. I assume it
>> works for you. Did you test it on GuixSD or on a foreign distro?
>>
>>> ---
>>> gnu/packages/pulseaudio.scm | 34 ++++++++++++++++++++++++++++++++++
>>> 1 file changed, 34 insertions(+)
>>
>> [...]
>>
>>> +(define-public paprefs
>>> + (package
>>> + (name "paprefs")
>>> + (version "0.9.10")
>>> + (source (origin
>>> + (method url-fetch)
>>> + (uri (string-append
>>> + "https://freedesktop.org/software/pulseaudio/paprefs/paprefs-"
>>> + version
>>> + ".tar.xz"))
>>
>> I'd prefer if the URL started directly after string-append, and then
>> used the minimum number of lines, while staying within the 80 character
>> limit. I can correct this sort of thing when applying patches, but I
>> must say it out loud once in a while ;)
>>
>>> + (sha256
>>> + (base32
>>> + "1c5b3sb881szavly220q31g7rvpn94wr7ywlk00hqb9zaikml716"))))
>>> + (build-system gnu-build-system)
>>> + (arguments
>>> + '(#:configure-flags '("CXXFLAGS=-std=c++11"))) ; required by gtkmm
>>> + (inputs
>>> + `(("pulseaudio" ,pulseaudio)
>>> + ("gconfmm" ,gconfmm)
>>> + ("lynx" ,lynx) ; used for documentation generation
>>
>> If it's only used to generate the docs, can we make it a native-input,
>> so it's only available while building?
>>
>>> + ("libglademm" ,libglademm)
>>> + ("dbus-glib" ,dbus-glib)))
>>> + (native-inputs
>>> + `(("intltool" ,intltool)
>>> + ("pkg-config" ,pkg-config)))
>>> + (home-page "https://freedesktop.org/software/pulseaudio/paprefs/")
>>> + (synopsis "simple configuration dialog for PulseAudio")
>>
>> The linter whines that the synopsis does not start with a capital
>> letter. What, you don't like the linter? ;)
>>
>>> + (description
>>> + "PulseAudio Preferences (paprefs) is a simple GTK+ based configuration
>>> +dialog for the PulseAudio sound server.")
>>> + (license l:gpl2+)))
>>> --
>>> 2.7.0
>>>
>>>
>>
>
> --
> ng0
>
>
--
♥Ⓐ ng0 | PGP keys and more: https://n0is.noblogs.org/
| http://ng0.chaosnet.org
prev parent reply other threads:[~2016-12-20 15:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 15:02 [PATCH] Add paprefs and dependencies Christopher Baines
2016-02-17 15:02 ` [PATCH 1/3] gnu: Add gconfmm Christopher Baines
2016-02-20 5:32 ` Leo Famulari
2016-02-20 8:48 ` Alex Kost
2016-02-17 15:02 ` [PATCH 2/3] gnu: Add libglademm Christopher Baines
2016-02-20 5:33 ` Leo Famulari
2016-02-29 9:55 ` Ludovic Courtès
2016-02-17 15:02 ` [PATCH 3/3] gnu: Add paprefs Christopher Baines
2016-02-20 5:39 ` Leo Famulari
2016-09-29 9:25 ` ng0
2016-12-20 15:35 ` ng0 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mvfqwr4k.fsf@wasp.i-did-not-set--mail-host-address--so-tickle-me \
--to=ng0@libertad.pw \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.