From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Marusich Subject: Re: [PATCH] gnu: Add asunder. Date: Fri, 23 Dec 2016 18:11:44 -0800 Message-ID: <87mvfmnkin.fsf@gmail.com> References: <20161217092040.3112-1-cmmarusich@gmail.com> <20161217092040.3112-2-cmmarusich@gmail.com> <20161217185621.GC1726@jasmine> <878trd7gmz.fsf@gmail.com> <87d1gj12nb.fsf@gmail.com> <20161223163640.GA8463@jasmine> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46077) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cKboN-0005Ve-5e for guix-devel@gnu.org; Fri, 23 Dec 2016 21:11:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cKboL-00018m-UO for guix-devel@gnu.org; Fri, 23 Dec 2016 21:11:51 -0500 Received: from mail-pf0-x244.google.com ([2607:f8b0:400e:c00::244]:34576) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cKboL-00018D-O7 for guix-devel@gnu.org; Fri, 23 Dec 2016 21:11:49 -0500 Received: by mail-pf0-x244.google.com with SMTP id y68so14489156pfb.1 for ; Fri, 23 Dec 2016 18:11:49 -0800 (PST) In-Reply-To: <20161223163640.GA8463@jasmine> (Leo Famulari's message of "Fri, 23 Dec 2016 11:36:40 -0500") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Leo Famulari writes: > On Fri, Dec 23, 2016 at 12:16:24AM -0800, Chris Marusich wrote: >> Hi Leo, >>=20 >> I've responded to the feedback from you, Hartmut, and John. How does >> the latest patch look? It's available here: >>=20 >> https://lists.gnu.org/archive/html/guix-devel/2016-12/msg00707.html > > Thanks for the reminder! I pushed as > 426e6083ae9d4569005dab8edf948485e5979171. > > I think it would be useful to figure out if it's possible to avoid the > wrapper somehow, but I didn't look into this closely. I'm sure we could avoid the wrapper by patching the source, but why would that be better? The wrapper is a simple and robust solution, and in this case I can't see any drawbacks to using it. For context, Asunder assumes that various tools will be made available via the PATH environment variable. It refuses to function in certain cases when a tool that it needs can't be found in the PATH. I'm sure we could patch this mechanism, but it seems simpler to just create a wrapper that puts the directories containing the tools onto the PATH. =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAlhd2WAACgkQ3UCaFdgi Rp0CuQ/9HDsBSa/9DHNhZnQPgcYxo3aBe66l7lyZ638fgWOK3lmRBVaj/X1pDVg9 57YYPIU1/xlSwjnEmzgoIVrzmWz05YGVYVVgcPUCKCKhW5ugwlFt5xql3l9m3OGP K2Sj3b0rcwS7x8wMTQBboVahr2Q8Te7spriC+iuadfEfknQgSbZesMPcu9KTkVOA 7jMKKjUMaw7X//MmC66PVlR1LtCBbKxa1KxdNmzorjjtxmIEZ05MxuKDiXatcR39 DcQny1JdOEazTqSRP334N8RgiwMRZYypm/oTLDMHg/EyVwS7Gf9leWXh16z2Na2z ojEbnoeQ7KrKRlbzzzv+bPVF8djAVdg2NhVLm5Fl+6MoxHYqSYq/Yv9ziINx5oeP i3enfgqZKqMD/FLjMivABIv1rTtzXmKtoPHYaEOKwmGd+lCZdUVV59m+0IgqOa9G gEaACBh/PrU0E5pNsB/dSq2H8uajLriW+1xpIMZJD0FJxlbG7vWxS3MqRhgqMMRU rbsOkuSrHS0cGxw+Fe6ZlDhoo1syWwhWoPmQ83fdhajg9cIppHsCS7dcO81UHegf ohDM3hig5JhMbKYMK2NjX95+Y9ZgYbfTCm7/NdJ9za9gArzQdkFXfwv9+rs5B9bs dQkwvkckN6M/p0Al24V2Y8337IxxVEOeHSMPM0w52h3yoTUlz+M= =kZ8H -----END PGP SIGNATURE----- --=-=-=--