From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: Seeking advice: preparing releases on GuixSD. Date: Sun, 25 Dec 2016 13:37:01 +0100 Message-ID: <87mvfknq1e.fsf@elephly.net> References: <874m1uvkdz.fsf@wasp.i-did-not-set--mail-host-address--so-tickle-me> <874m1ty6rd.fsf@elephly.net> <87inq9vu9n.fsf@wasp.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36727) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cL837-0001qL-UZ for help-guix@gnu.org; Sun, 25 Dec 2016 07:37:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cL834-0002Nj-RB for help-guix@gnu.org; Sun, 25 Dec 2016 07:37:13 -0500 Received: from sender-of-o52.zoho.com ([135.84.80.217]:21365) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cL834-0002Na-Jb for help-guix@gnu.org; Sun, 25 Dec 2016 07:37:10 -0500 In-reply-to: <87inq9vu9n.fsf@wasp.i-did-not-set--mail-host-address--so-tickle-me> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-guix-bounces+gcggh-help-guix=m.gmane.org@gnu.org Sender: "Help-Guix" To: ng0 Cc: help-guix@gnu.org ng0 writes: > Ricardo Wurmus writes: [=E2=80=A6] >> From af81a0a3c796af583ec88dd4bc8d2e8a742c58fa Mon Sep 17 00:00:00 2001 >> From: Ricardo Wurmus >> Date: Sat, 24 Dec 2016 11:12:45 +0100 >> Subject: [PATCH] gnu: Add roffit. >> >> * gnu/packages/groff.scm (roffit): New variable. [=E2=80=A6] >> +;; There are no releases, so we take the latest commit. >> +(define-public roffit >> + (let ((commit "e5228388e3faf2b7f1ae5bd048ad46ed565304c6") >> + (revision "1")) >> + (package >> + (name "roffit") >> + (version (string-append "0.11-" revision "." (string-take commit = 9))) >> + (source (origin >> + (method git-fetch) >> + (uri (git-reference >> + (url "https://github.com/bagder/roffit.git") >> + (commit commit))) >> + (file-name (string-append "roffit-" commit "-checkout")) >> + (sha256 >> + (base32 >> + "1y7ndbqciy7h0khlpi1bv4v1614vhybnmm4jysj6fwxkw9cwv1nc= ")))) >> + (build-system gnu-build-system) >> + (arguments >> + `(#:test-target "test" >> + #:make-flags >> + (list (string-append "INSTALLDIR=3D" >> + (assoc-ref %outputs "out") "/bin")) >> + #:phases >> + (modify-phases %standard-phases >> + (delete 'configure) >> + (add-before 'install 'pre-install >> + (lambda* (#:key outputs #:allow-other-keys) >> + (mkdir-p (string-append (assoc-ref outputs "out") >> + "/bin")) >> + #t))))) > > My only difference is in the (arguments), where I do: > > (arguments > `(#:test-target "test" > #:phases > (modify-phases %standard-phases > (replace 'configure ; No configure phase > (lambda* (#:key outputs #:allow-other-keys) > (let* ((out (assoc-ref outputs "out")) > (bin (string-append out "/bin/"))) > (substitute* "Makefile" > (("/usr/local/bin") > bin)) That=E2=80=99s not necessary, because we can override INSTALLDIR. > (mkdir-p bin)))) > (add-after 'install 'wrap-programs > (lambda* (#:key outputs #:allow-other-keys) > ;; Make sure all executables in "bin" find the Perl modules > ;; provided by this package at runtime. > (let* ((out (assoc-ref outputs "out")) > (bin (string-append out "/bin/")) > (path (getenv "PERL5LIB"))) > (for-each (lambda (file) > (wrap-program file > `("PERL5LIB" ":" prefix (,path)))) > (find-files bin "\\.*$")) > #t)))))) Why would this be necessary? There are no Perl packages among the inputs. --=20 Ricardo =20=20 GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC http://elephly.net