From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 2/2] services: Add openvswitch-service-type.
Date: Sun, 29 Jan 2017 01:02:30 +0100
Message-ID: <87mveaybqh.fsf@gnu.org>
References: <20170127135616.15017-1-iyzsong@member.fsf.org>
	<20170127135616.15017-2-iyzsong@member.fsf.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35341)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cXcx1-0004MI-TC
	for guix-devel@gnu.org; Sat, 28 Jan 2017 19:02:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cXcwy-0005gz-Qz
	for guix-devel@gnu.org; Sat, 28 Jan 2017 19:02:35 -0500
In-Reply-To: <20170127135616.15017-2-iyzsong@member.fsf.org>
	(=?utf-8?B?IuWui+aWh+atpiIncw==?=
	message of "Fri, 27 Jan 2017 21:56:16 +0800")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@member.fsf.org>
Cc: guix-devel@gnu.org

=E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@member.fsf.org> skribis:

> * gnu/services/networking.scm (<openvswitch-configuration>): New record t=
ype.
> (openvswitch-activation, openvswitch-shepherd-service): New procedures.
> (openvswitch-service-type): New variable.
> * doc/guix.texi (Networking Services): Document it.

[...]

> +@deftp {Data Type} openvswitch-configuration
> +Data type representing the configuration of openvswitch.

s/openvswitch/Open vSwitch, the blah blah networking blah/

> +       #~(begin
> +           (use-modules (guix build utils))

Better with:

  (with-imported-modules '((guix build utils))
    #~(begin
        (use-modules (guix build utils))
        =E2=80=A6))

> +         (start #~(make-forkexec-constructor
> +                   (list #$ovsdb-server
> +                         "--remote=3Dpunix:/var/run/openvswitch/db.sock"=
)))

If it produces a PID file, use #:pid-file here.

OK with these changes, thanks!

Ludo=E2=80=99.