From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Huang\, Ying" Subject: Re: Could anyone help me to pack the shellcheck (haskell) Date: Sun, 12 Mar 2017 16:03:22 +0800 Message-ID: <87mvcqx6ph.fsf@163.com> References: <87innkkm2e.fsf@163.com> <20170308220438.74ffa36c@scratchpost.org> <87mvcun0go.fsf@163.com> <20170309193441.494c63b6@scratchpost.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47479) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cmyTZ-0000dU-Uy for guix-devel@gnu.org; Sun, 12 Mar 2017 04:03:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cmyTX-0003NR-AI for guix-devel@gnu.org; Sun, 12 Mar 2017 04:03:37 -0400 Received: from m12-11.163.com ([220.181.12.11]:48112) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cmyTV-0003L9-Hn for guix-devel@gnu.org; Sun, 12 Mar 2017 04:03:35 -0400 In-Reply-To: <20170309193441.494c63b6@scratchpost.org> (Danny Milosavljevic's message of "Thu, 9 Mar 2017 19:34:41 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Danny Milosavljevic Cc: guix-devel Danny Milosavljevic writes: > Hi, > > On Thu, 09 Mar 2017 19:39:19 +0800 > "Huang\, Ying" wrote: > >> Danny Milosavljevic writes: >> >> > Hi, >> > >> > On Wed, 08 Mar 2017 20:08:41 +0800 >> > "Huang\, Ying" wrote: >> > >> >> I know very little about Haskell, but I use shellcheck >> >> (https://github.com/koalaman/shellcheck) to check my shell scripts. I >> >> tried myself, but found it is hard for me. Could anyone help me on >> >> that? >> >> Great! It works! > > Nice. Good to know that it works for you as-is. > >>Thanks a lot! Now I can use shellcheck. Could you >> make it merged by Guix? > > Eventually, but it has to go through the normal review process in any case. > > Could you give some details for the description? I'm not a user of shellcheck so I have no idea what else to put there. Copied from the README of the shellcheck, I think this is a more detailed description. ShellCheck is a GPLv3 tool that gives warnings and suggestions for bash/sh shell scripts. The goals of ShellCheck are, - To point out and clarify typical beginner's syntax issues that cause a shell to give cryptic error messages. - To point out and clarify typical intermediate level semantic problems that cause a shell to behave strangely and counter-intuitively. - To point out subtle caveats, corner cases and pitfalls that may cause an advanced user's otherwise working script to fail under future circumstances. > Also, could you do a license review (check the shellcheck source files for header comments which say what license to use) and make sure it's actually gpl3 or later ? Check all *.hs files in the shellcheck. All files except ShellCheck/Data.hs has header comments which say gpl3 or later is used. The ShellCheck/Data.hs has no header comments about copyright and there are only several variable definitions in the file. Best Regards, Huang, Ying > Then I'll post an updated patch to guix-patches (to be merged eventually after review) if you want.