From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#25917: [PATCH] file-systems: Factorize file-system-packages.
Date: Sat, 18 Mar 2017 12:00:47 +0100
Message-ID: <87mvcialy8.fsf@gnu.org>
References: <20170316174029.1663-1-dannym@scratchpost.org>
	<87efxwi8av.fsf@gnu.org> <20170317131958.734cdfba@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46842)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cpC6b-00054B-Hs
	for bug-guix@gnu.org; Sat, 18 Mar 2017 07:01:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cpC6Y-0002z8-RZ
	for bug-guix@gnu.org; Sat, 18 Mar 2017 07:01:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:35089)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1cpC6Y-0002z4-MI
	for bug-guix@gnu.org; Sat, 18 Mar 2017 07:01:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cpC6Y-0005pS-Bu
	for bug-guix@gnu.org; Sat, 18 Mar 2017 07:01:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.25917.B25917.148983486022391@debbugs.gnu.org>
In-Reply-To: <20170317131958.734cdfba@scratchpost.org> (Danny Milosavljevic's
	message of "Fri, 17 Mar 2017 13:19:58 +0100")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 25917@debbugs.gnu.org

Hello!

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> On Fri, 17 Mar 2017 10:03:52 +0100
> ludo@gnu.org (Ludovic Court=C3=A8s) wrote:
>
>> You can also remove the now-unused =E2=80=98file-system-type-predicate=
=E2=80=99
>> procedure that is in =E2=80=98base-initrd=E2=80=99.
>
> It's still used there (in order to determine the Linux modules).  Should =
I also export 'file-system-type-predicate` from file-systems.scm and use th=
at in 'base-initrd` ?  I thought it was too special-case to be a public fun=
ction.
>
> Also, it seems that the new version (which now uses `set-path-environment=
-variable') clears the old PATH whereas the previous version prepended to i=
t.
>
> The previous version has:
>
>                              (setenv "PATH"
>                                      (string-append
>                                       #$e2fsprogs "/sbin:"
>                                       "/run/current-system/profile/sbin:"
>                                       $PATH)))
>
> (What does "$" without "#" do?)

#$ is synonymous for =E2=80=98ungexp=E2=80=99; $ alone has no special meani=
ng, and $PATH
is a regular identifier.

> The new version would have:
>
>                            (lambda ()
>                              (set-path-environment-variable "PATH"
>                                                             '("bin" "sbin=
")
>                                                             '#$packages))
>
> It works fine - however, I get a warning that PATH has been unset at boot=
up.

You could shut it up like this:

  ;; Don=E2=80=99t display the PATH settings.
  (with-output-to-port (%make-void-port "w")
    (lambda ()
      (set-path-environment-variable =E2=80=A6)))

> What's up with the hard-coded "/run/current-system/profile/sbin" ?

I traced it back to 1b09031f786238b21ab10ba4c3e384ab194735df.  I think
you can remove it (probably the idea was that we were =E2=80=9Clikely=E2=80=
=9D to find
other fsck commands in /run/current-system/profile/sbin, not very
reliable=E2=80=A6).

HTH!

Ludo=E2=80=99.