From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: 01/01: gnu: glibc/linux: Fix runtime crashes on i686 systems. Date: Sun, 30 Apr 2017 11:00:34 +0200 Message-ID: <87mvayqngt.fsf@elephly.net> References: <20170429213253.6080.61219@vcs0.savannah.gnu.org> <20170429213255.095472109D@vcs0.savannah.gnu.org> <87bmrewbrp.fsf@netris.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35733) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d4kin-0000j0-Vc for guix-devel@gnu.org; Sun, 30 Apr 2017 05:00:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d4kik-0007t5-O3 for guix-devel@gnu.org; Sun, 30 Apr 2017 05:00:49 -0400 Received: from sender-of-o51.zoho.com ([135.84.80.216]:21142) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d4kik-0007su-Fo for guix-devel@gnu.org; Sun, 30 Apr 2017 05:00:46 -0400 In-reply-to: <87bmrewbrp.fsf@netris.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Mark H Weaver Cc: guix-devel@gnu.org Hi Mark, > rekado@elephly.net (Ricardo Wurmus) writes: > >> rekado pushed a commit to branch master >> in repository guix. >> >> commit b2fd8f63679aa4f244c36fdca62f23c00b8eded9 >> Author: Ricardo Wurmus >> Date: Wed Apr 26 13:03:48 2017 +0200 >> >> gnu: glibc/linux: Fix runtime crashes on i686 systems. >> >> * gnu/packages/patches/glibc-memchr-overflow-i686.patch: New file. >> * gnu/local.mk (dist_patch_DATA): Add it. >> * gnu/packages/commencement.scm (glibc-final-with-bootstrap-bash)[native-inputs]: >> Add the patch conditionally for i686 systems. >> * gnu/packages/base.scm (glibc/linux)[native-inputs]: Add the patch >> conditionally for i686 systems. >> [arguments]: Apply the patch conditionally on i686 systems. > > Thanks very much for this. I noticed a minor issue with this patch: […] Thanks for your comments. You’re right. I’ve also noticed that something’s wrong with this patch, even though it appeared to work fine when cross-building glibc on my x86_64 machine. I’ll fix these issues shortly. -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net