[PATCH] Add neofetch to games.scm doubleplusgood23@gmail.com

[PATCH] Add neofetch to games.scm doubleplusgood23@gmail.com

[doubleplusgood23]

[-- Attachment #1: Type: text/plain, Size: 48 bytes --]

Pretty small patch for my first time commiting. 

[-- Attachment #2: neofetch patch --]
[-- Type: text/x-patch, Size: 2437 bytes --]

From ff50a931905376440f245c37df620d724a78dde9 Mon Sep 17 00:00:00 2001
From: "Ethan R. Jones" <doubleplusgood23@gmail.com>
Date: Fri, 5 May 2017 22:02:48 -0400
Subject: [PATCH] Adding neofetch to the games package expression.

---
 gnu/packages/games.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index b31bb93db..b0831b4a0 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -28,6 +28,7 @@
 ;;; Copyright © 2017 Arun Isaac <arunisaac@systemreboot.net>
 ;;; Copyright © 2017 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;; Copyright © 2017 nee <nee-git@hidamari.blue>
+;;; Copyright © 2017 Ethan "dpg" Jones <doubleplusgood23@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -3941,3 +3942,37 @@ fabulous Orb of Zot.")
                    license:expat
                    license:zlib
                    license:asl2.0))))
+
+(define-public neofetch
+  (package
+    (name "neofetch")
+    (version "3.1.0")
+    (source (origin
+              (method git-fetch)
+              (uri
+               (git-reference
+                (url "https://github.com/dylanaraps/neofetch.git")
+                (commit version)))
+              (file-name (string-append name "-" version))
+              (sha256
+               (base32
+                "0z2ch1j9m5xsdaqn89dd7xlick67jfqpa90mb4djyycgak9751ca"))))
+    (build-system gnu-build-system)
+    (arguments
+     '(#:tests? #f ;; Because neofetch is a bash script it only needs make install.
+       #:strip-binaries? #f
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure)
+         (delete 'build))
+       #:make-flags  ;; We need to the Makefile to output to our proper store.
+       (list (string-append "DESTDIR=" %output))))
+    (inputs `(("bash" ,bash)))  ;; Only requires bash!
+    (synopsis "System info script")
+    (description "Neofetch is a CLI system information tool written in
+BASH.  Neofetch displays information about your system next to an image, your OS
+logo, or any ASCII file of your choice.  The main purpose of Neofetch is
+to be used in screenshots to show other users what OS/Distro you're
+running, what Theme/Icons you're using etc.  ")
+    (home-page "https://github.com/dylanaraps/neofetch")
+    (license license:expat)))
-- 
2.12.2

Re: [PATCH] Add neofetch to games.scm doubleplusgood23@gmail.com

[Arun Isaac]

Thank you for your contribution!

> Pretty small patch for my first time commiting. From ff50a931905376440f245c37df620d724a78dde9 Mon Sep 17 00:00:00 2001
> From: "Ethan R. Jones" <doubleplusgood23@gmail.com>
> Date: Fri, 5 May 2017 22:02:48 -0400
> Subject: [PATCH] Adding neofetch to the games package expression.

Please look at earlier commit messages in the git log. Your commit
message should be something like:

gnu: Add neofetch.

* gnu/packages/games.scm (neofetch): New variable.

> ---
>  gnu/packages/games.scm | 35 +++++++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)

I don't think we should put this package in games.scm. But, I am unable
to think of a good alternative. Ideas?

> +(define-public neofetch
> +  (package
> +    (name "neofetch")
> +    (version "3.1.0")
> +    (source (origin
> +              (method git-fetch)
> +              (uri
> +               (git-reference
> +                (url "https://github.com/dylanaraps/neofetch.git")
> +                (commit version)))

Please use the latest release tarball instead of the git checkout.

> +    (arguments
> +     '(#:tests? #f ;; Because neofetch is a bash script it only needs make install.

This comment can just say "No tests"

> +       #:strip-binaries? #f

Do we need this? If the build does not fail without this, and there are
no other issues, you can remove this argument.

Also, you should send patches to guix-patches@gnu.org. We were using
guix-devel@gnu.org before, but now all patches go to
guix-patches, and guix-devel is used only for discussion. Could you make
the above changes and send the new patch to guix-patches@gnu.org?

Re: [PATCH] Add neofetch to games.scm doubleplusgood23@gmail.com

[Alex Kost]

doubleplusgood23@gmail.com (2017-05-05 22:13 -0400) wrote:

> Pretty small patch for my first time commiting.

Hello and welcome!  I also have a couple of notes additionally to what
Arun wrote.

> From ff50a931905376440f245c37df620d724a78dde9 Mon Sep 17 00:00:00 2001
> From: "Ethan R. Jones" <doubleplusgood23@gmail.com>
> Date: Fri, 5 May 2017 22:02:48 -0400
> Subject: [PATCH] Adding neofetch to the games package expression.
>
> ---
>  gnu/packages/games.scm | 35 +++++++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index b31bb93db..b0831b4a0 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -28,6 +28,7 @@
>  ;;; Copyright © 2017 Arun Isaac <arunisaac@systemreboot.net>
>  ;;; Copyright © 2017 Tobias Geerinckx-Rice <me@tobias.gr>
>  ;;; Copyright © 2017 nee <nee-git@hidamari.blue>
> +;;; Copyright © 2017 Ethan "dpg" Jones <doubleplusgood23@gmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -3941,3 +3942,37 @@ fabulous Orb of Zot.")
>                     license:expat
>                     license:zlib
>                     license:asl2.0))))
> +
> +(define-public neofetch
> +  (package
> +    (name "neofetch")
> +    (version "3.1.0")
> +    (source (origin
> +              (method git-fetch)
> +              (uri
> +               (git-reference
> +                (url "https://github.com/dylanaraps/neofetch.git")
> +                (commit version)))

We usually use 'url-fetch' with a tarball snapshot (not sure if there is a
preference though):

  https://github.com/dylanaraps/neofetch/archive/3.1.0.tar.gz

> +              (file-name (string-append name "-" version))
> +              (sha256
> +               (base32
> +                "0z2ch1j9m5xsdaqn89dd7xlick67jfqpa90mb4djyycgak9751ca"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     '(#:tests? #f ;; Because neofetch is a bash script it only needs make install.
> +       #:strip-binaries? #f
> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure)
> +         (delete 'build))
> +       #:make-flags  ;; We need to the Makefile to output to our proper store.
> +       (list (string-append "DESTDIR=" %output))))
> +    (inputs `(("bash" ,bash)))  ;; Only requires bash!
> +    (synopsis "System info script")
> +    (description "Neofetch is a CLI system information tool written in
> +BASH.  Neofetch displays information about your system next to an image, your OS
> +logo, or any ASCII file of your choice.  The main purpose of Neofetch is
> +to be used in screenshots to show other users what OS/Distro you're
> +running, what Theme/Icons you're using etc.  ")
                                              ^^
Please remove those spaces.

> +    (home-page "https://github.com/dylanaraps/neofetch")
> +    (license license:expat)))

-- 
Alex

Re: [PATCH] Add neofetch to games.scm doubleplusgood23@gmail.com

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 630 bytes --]

On Mon, May 08, 2017 at 08:27:07PM +0300, Alex Kost wrote:
> > +    (version "3.1.0")
> > +    (source (origin
> > +              (method git-fetch)
> > +              (uri
> > +               (git-reference
> > +                (url "https://github.com/dylanaraps/neofetch.git")
> > +                (commit version)))
> 
> We usually use 'url-fetch' with a tarball snapshot (not sure if there is a
> preference though):
> 
>   https://github.com/dylanaraps/neofetch/archive/3.1.0.tar.gz

Unless we need a specific Git commit, I think url-fetch is better
because it has fewer dependencies. Git is a huge package.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]