From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37328) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d7lV3-0002tj-QW for guix-patches@gnu.org; Mon, 08 May 2017 12:27:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d7lV0-0000Dv-Ly for guix-patches@gnu.org; Mon, 08 May 2017 12:27:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:36423) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d7lV0-0000Dq-IR for guix-patches@gnu.org; Mon, 08 May 2017 12:27:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d7lV0-0004BQ-DI for guix-patches@gnu.org; Mon, 08 May 2017 12:27:02 -0400 Subject: bug#26339: [PATCH v3 7/9] scripts: system: Adapt "init" to new bootloader API. Resent-Message-ID: References: <20170506154154.17836-1-m.othacehe@gmail.com> <20170506154154.17836-8-m.othacehe@gmail.com> <20170507230829.22f0ce70@scratchpost.org> From: Mathieu Othacehe In-reply-to: <20170507230829.22f0ce70@scratchpost.org> Date: Mon, 08 May 2017 18:26:17 +0200 Message-ID: <87mvans4ba.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Danny Milosavljevic Cc: 26339@debbugs.gnu.org > "bootloader-installer.drv" instead of "installer"? I think that bootloader-installer is fine as per reconfigure. > >>[reinstall-bootloader] >> - (install-proc >> + (installer >> (let ((procedure (bootloader-configuration-installer >> (operating-system-bootloader os))) >> (target (or target "/"))) > > "installer.drv" instead of "installer", and "installer" instead of "procedure". Also, deja vu. Patch 6/9 also includes something of this part. Ok for install-proc -> bootloader-install and procedure -> installer as per reconfigure. > > Otherwise LGTM!