From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54178)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dAysz-00008u-K4
	for guix-patches@gnu.org; Wed, 17 May 2017 09:21:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dAysw-0007Gp-74
	for guix-patches@gnu.org; Wed, 17 May 2017 09:21:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:47051)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dAysw-0007GX-2i
	for guix-patches@gnu.org; Wed, 17 May 2017 09:21:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dAysv-0004r3-Ph
	for guix-patches@gnu.org; Wed, 17 May 2017 09:21:01 -0400
Subject: bug#26934: [PATCH 1/3] gnu: video: add libzen
Resent-Message-ID: <handler.26934.B26934.149502722618612@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170515025701.2492-1-doubleplusgood23@gmail.com>
Date: Wed, 17 May 2017 15:20:12 +0200
In-Reply-To: <20170515025701.2492-1-doubleplusgood23@gmail.com> (Ethan
	R. Jones's message of "Sun, 14 May 2017 22:56:59 -0400")
Message-ID: <87mvabwrg3.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: "Ethan R. Jones" <doubleplusgood23@gmail.com>
Cc: 26934@debbugs.gnu.org

Hello Ethan,

Thanks for the patch set.  Overall the patches look good to me modulo
minor issues that I=E2=80=99ll comment on:

"Ethan R. Jones" <doubleplusgood23@gmail.com> skribis:

> ---
>  gnu/packages/video.scm | 42 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 42 insertions(+)

Could you provide ChangeLog-style commit logs?  See =E2=80=98git log=E2=80=
=99 for
examples and <https://gnu.org/s/guix/manual/html_node/Submitting-Patches.ht=
ml>.

> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://mediaarea.net/download/source=
/"
> +                                  name
> +                                  "/"
> +                                  version
> +                                  "/"
> +                                  name
> +                                  "_"
> +                                  version
> +                                  ".tar.bz2"))

Could you squeeze that on one or two lines?

> +    (native-inputs
> +     `(("autoconf" ,autoconf)
> +       ("automake" ,automake)
> +       ("libtool" ,libtool)))

[...]

> +         (add-before 'configure 'autogen
> +           (lambda _
> +             (zero? (system* "./autogen.sh")))))))

Please double-check that this is needed.  Usually, but not always,
projects that use Autoconf & co. provide self-contained tarballs such
that one doesn=E2=80=99t need to run ./autogen.sh.

> +    (home-page "https://mediaarea.net/en/MediaInfo")
> +    (synopsis "Library for libmediainfo")
> +    (description "Shared library for libmediainfo and mediainfo.")

Could you improve the synopsis and description according to the
guidelines at
<https://gnu.org/s/guix/manual/html_node/Synopses-and-Descriptions.html>?

Please take a look at
<https://gnu.org/s/guix/manual/html_node/Submitting-Patches.html> if you
haven=E2=80=99t already.

Could you send updated patches?

Thanks in advance!

Ludo=E2=80=99.