From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40542)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dCqCd-0007h8-Px
	for guix-patches@gnu.org; Mon, 22 May 2017 12:29:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dCqCc-0005Bp-SY
	for guix-patches@gnu.org; Mon, 22 May 2017 12:29:03 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:58677)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dCqCc-0005Bl-PJ
	for guix-patches@gnu.org; Mon, 22 May 2017 12:29:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dCqCc-0000Dn-Ge
	for guix-patches@gnu.org; Mon, 22 May 2017 12:29:02 -0400
Subject: bug#26966: [PATCH 06/22] gnu: Add ecj-javac-wrapper.
Resent-Message-ID: <handler.26966.B26966.1495470540842@debbugs.gnu.org>
References: <20170517171905.7840-1-rekado@elephly.net>
	<20170517171905.7840-6-rekado@elephly.net> <rbuefvhs5mb.fsf@gnu.org>
	<87shjxw9sl.fsf@gnu.org>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <87shjxw9sl.fsf@gnu.org>
Date: Mon, 22 May 2017 18:28:39 +0200
Message-ID: <87mva4c0ug.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 26966@debbugs.gnu.org


Hi Ludo,

> Hi!
>
> Roel Janssen <roel@gnu.org> skribis:
>
>>> +           (with-output-to-file target
>>> +             (lambda _
>>> +               (format #t "#!~a --no-auto-compile\n!#\n" guile)
>>> +               (map write
>>> +                    `((use-modules (ice-9 match)
>>> +                                   (ice-9 receive)
>>> +                                   (ice-9 hash-table)
>>> +                                   (srfi srfi-1)
>>> +                                   (srfi srfi-26))
>>> +                      (define defaults
>>> +                        '(("-bootclasspath" ,bootcp)
>>> +                          ("-source" "1.5")
>>> +                          ("-target" "1.5")
>>> +                          ("-cp"     ".")))
>
> Minor nitpick: I would rather write this as
>
>   (write `(begin
>             (use-modules …)
>             (define …)
>             …)
>           port)
>
> because (1) ‘map’ returns a list of values, so ‘for-each’ would be more
> appropriate, and (2) I think sexps should be considered as a whole
> rather than as a list of sexps in general.

Yes, I totally forgot about “begin”!  That’s much nicer indeed!

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net