From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37097)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dKVzP-0005PV-Le
	for guix-patches@gnu.org; Mon, 12 Jun 2017 16:31:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dKVzK-0007R9-NU
	for guix-patches@gnu.org; Mon, 12 Jun 2017 16:31:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:41392)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dKVzK-0007R3-KL
	for guix-patches@gnu.org; Mon, 12 Jun 2017 16:31:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dKVzK-0000YI-Br
	for guix-patches@gnu.org; Mon, 12 Jun 2017 16:31:02 -0400
Subject: [bug#26339] [PATCH] tests: Add syslinux gpt test.
Resent-Message-ID: <handler.26339.B26339.14972994112066@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170402134916.2871-1-m.othacehe@gmail.com>
	<20170518102618.24842-1-m.othacehe@gmail.com>
Date: Mon, 12 Jun 2017 22:29:57 +0200
In-Reply-To: <20170518102618.24842-1-m.othacehe@gmail.com> (Mathieu Othacehe's
	message of "Thu, 18 May 2017 12:26:18 +0200")
Message-ID: <87mv9d3q62.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 26339@debbugs.gnu.org

Mathieu Othacehe <m.othacehe@gmail.com> skribis:

> * gnu/tests/install.scm (%test-installed-syslinux-os): New exported
>   variable.
>   (%minimal-syslinux-os, %minimal-syslinux-os-source): New variables.
>   (%syslinux-gpt-installation-script): New variable.
> * gnu/system/install.scm (installation-os)[packages]: Add syslinux.

Awesome!  It=E2=80=99s really helpful, a good way to avoid bitrot.

> --- a/gnu/system/install.scm
> +++ b/gnu/system/install.scm
> @@ -343,6 +343,7 @@ Use Alt-F2 for documentation.
>      (packages (cons* (canonical-package glibc) ;for 'tzselect' & co.
>                       parted gptfdisk ddrescue
>                       grub                  ;mostly so xrefs to its manua=
l work
> +                     syslinux

I don=E2=80=99t think we should provide =E2=80=98syslinux=E2=80=99 in the i=
nstallation image.
The image is already fat enough.

> +(define-os-with-source (%minimal-syslinux-os
> +                        %minimal-syslinux-os-source)

I think you can=E2=80=99t really avoid duplication because
=E2=80=98define-os-with-source=E2=80=99 needs to see the full source.  You =
could remove
the unnecessary bits like =E2=80=98users=E2=80=99 though.

> +(define %syslinux-gpt-installation-script
> +  ;; Shell script of a simple installation.
> +  ;; As syslinux 6.0.3 does not handle 64bits ext4 partitions,
> +  ;; we make sure to pass -O '^64bit' to mkfs.

Really?  Woow.

> +(define %test-installed-syslinux-os
> +  (system-test
> +   (name "installed-syslinux-os")
> +   (description
> +    "...")

Please expound a bit.  :-)

Otherwise LGTM, thank you!

Ludo=E2=80=99.