From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: bug#27311: Acknowledgement (Enlightenment: 'cpufreq binary needs suid
	or has to be owned by root')
Date: Wed, 21 Jun 2017 10:00:14 +0200
Message-ID: <87mv913h4h.fsf@elephly.net>
References: <20170610150323.qqys6t7febaalmra@abyayala>
	<handler.27311.B.149710706324063.ack@debbugs.gnu.org>
	<20170611163519.cbzr2s2xanftl33c@abyayala>
	<20170611172511.rgratbogpqv5aop3@abyayala>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51674)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dNaZY-00018L-7x
	for bug-guix@gnu.org; Wed, 21 Jun 2017 04:01:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dNaZS-0006pJ-Kz
	for bug-guix@gnu.org; Wed, 21 Jun 2017 04:01:08 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:56131)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dNaZS-0006p3-Hh
	for bug-guix@gnu.org; Wed, 21 Jun 2017 04:01:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dNaZS-0005JO-49
	for bug-guix@gnu.org; Wed, 21 Jun 2017 04:01:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.27311.B27311.149803202118236@debbugs.gnu.org>
In-reply-to: <20170611172511.rgratbogpqv5aop3@abyayala>
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: ng0 <ng0@pragmatique.xyz>
Cc: 27311@debbugs.gnu.org


ng0 <ng0@pragmatique.xyz> writes:

> Nix solved this particular issue (cpufreq) with a hack.
> It's okay for me, but do some of you agree with applying this:
>
>   # this is a hack and without this cpufreq module is not working. does the following:
>   #   1. moves the "freqset" binary to "e_freqset",
>   #   2. linkes "e_freqset" to enlightenment/bin so that,
>   #   3. wrappers.setuid detects it and places wrappers in /run/wrappers/bin/e_freqset,
>   #   4. and finally, links /run/wrappers/bin/e_freqset to original destination where enlightenment wants it
>   postInstall = ''
>     export CPUFREQ_DIRPATH=`readlink -f $out/lib/enlightenment/modules/cpufreq/linux-gnu-*`;
>     mv $CPUFREQ_DIRPATH/freqset $CPUFREQ_DIRPATH/e_freqset
>     ln -sv $CPUFREQ_DIRPATH/e_freqset $out/bin/e_freqset
>     ln -sv /run/wrappers/bin/e_freqset $CPUFREQ_DIRPATH/freqset
>   '';

No, we shouldn’t apply this hack.  Setuid binaries are declared
separately in the operating system configuration.  See section 6.2.8
Setuid Programs in the manual.

Packages cannot declare setuid binaries.

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net