From: Marius Bakke <mbakke@fastmail.com>
To: manolis837@gmail.com, 27971@debbugs.gnu.org
Subject: [bug#27971] [PATCH] gnu: Add ois.
Date: Tue, 08 Aug 2017 00:04:15 +0200 [thread overview]
Message-ID: <87mv7bavc0.fsf@fastmail.com> (raw)
In-Reply-To: <20170805170820.4766-1-manolis837@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1535 bytes --]
manolis837@gmail.com writes:
> From: Manolis Ragkousis <manolis837@gmail.com>
>
> * gnu/packages/game-development.scm (ois): New variable.
[...]
> +(define-public ois
> + (package
> + (name "ois")
> + (version "1.3")
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "git://github.com/wgois/OIS.git")
> + (commit "bb75ccc1aabc1c547195579963601ff6080ca2f2")))
Can you add a note about why we need a git checkout? Also, please use
HTTPS here.
> + (file-name (string-append name "-" version))
> + (sha256
> + (base32
> + "0w0pamjc3vj0jr718hysrw8x076fq6n9rd6wcb36sn2jd0lqvi98"))))
> + (build-system gnu-build-system)
> + (arguments
> + `(#:phases
> + (modify-phases %standard-phases
> + (add-before 'configure 'bootstrap
> + (lambda _ (zero? (system* "sh" "bootstrap")))))))
This should be done after 'unpack' to not compete against the various
'patch-shebang' phases.
> + (native-inputs
> + `(("autoconf" ,autoconf)
> + ("automake" ,automake)
> + ("libtool" ,libtool)
> + ("m4" ,m4)
> + ("pkg-config" ,pkg-config)))
> + (inputs
> + `(("libxaw" ,libxaw)))
> + (synopsis "Object Oriented Input System")
> + (description
> + "Cross Platform Object Oriented Input Lib System. Meant to be very robust
> +and compatiable with many systems and operating systems.")
^^^ typo
Feel free to expand on the description if you can, but LGTM.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2017-08-07 22:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-05 17:08 [bug#27971] [PATCH] gnu: Add ois manolis837
2017-08-07 22:04 ` Marius Bakke [this message]
2017-08-08 20:45 ` manolis837
2017-08-08 21:15 ` Marius Bakke
2017-08-09 11:04 ` bug#27971: " Manolis Ragkousis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mv7bavc0.fsf@fastmail.com \
--to=mbakke@fastmail.com \
--cc=27971@debbugs.gnu.org \
--cc=manolis837@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.