From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48819) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1do5wF-0001jS-GM for guix-patches@gnu.org; Sat, 02 Sep 2017 06:46:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1do5wA-0001te-MK for guix-patches@gnu.org; Sat, 02 Sep 2017 06:46:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:32842) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1do5wA-0001tR-Iq for guix-patches@gnu.org; Sat, 02 Sep 2017 06:46:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1do5wA-0006PA-B4 for guix-patches@gnu.org; Sat, 02 Sep 2017 06:46:02 -0400 Subject: bug#28253: perl-www-opensearch: provide Test-Simple module Resent-To: guix-patches@gnu.org Resent-Message-ID: From: Marius Bakke In-Reply-To: <20170828212419.67jazbi5fzouyki3@abyayala> References: <20170827182855.sxmgbz4wpjfstdob@abyayala> <87d17fzbb4.fsf@fastmail.com> <20170828205938.p4dlnm7qp6rdmrdu@abyayala> <20170828212419.67jazbi5fzouyki3@abyayala> Date: Sat, 02 Sep 2017 12:45:15 +0200 Message-ID: <87mv6dl6pw.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: ng0 , 28253-done@debbugs.gnu.org --=-=-= Content-Type: text/plain ng0 writes: > Updated patch with a small comment grammar fix. > > Purpose of this patch: to add a dependency which was > previously unknown and had to be figured out by the > person who would try to fix the tests. So to go from > "nothing, uh what do we need here?" to > "hey, we have the test dependency" is an improvement > and not just a "work in progress" one-liner. Right. I don't think adding dependencies that does not change anything with the package is very useful. A comment stating that this dependency would be needed to enable tests would do the same purpose without changing the derivation. But, it would take any packager about 20 seconds to find that Test::Simple is needed, so it's kind of "stating the obvious". Anyway I tried building this package with tests enabled and just kept adding the modules it could not find as native-inputs until it succeeded. So I pushed a superset of this patch as 3fe666aa29e72a9fbb1e267eebcd7d197ec802f3. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlmqi7sACgkQoqBt8qM6 VPrwnAf/ZgM43LFnP0khjzEglz/LwP9S+GjUWVEvsf+IttmTmQZltIna9JRY3lBH Ynpj/MEXhgx4b74dQpqNZtHKPk1LD38EwCJTiQBS1pvBedqz84EQzW6FyXvbVbAE Z51GaSvcF1iWjITPmgH8AJzMuYrLkXQ6F85hXjPEiD6OGVGEzNiwQdJ2aEdYnSXe 6ZtVA0BwQP5GQ78+/Ik3iGKgWohUif1tiAvdHdSmXJeWcMTmTNk/jBDKcS0Ihe1t uCyn+Gh3FOkSl8+lzngF1PtXR+vUPWQMgeHpERFbxOePmONtl98Bql9VsS80YvMC IchvdPyENL2WebJ2NUjlICkCJ1s5uw== =wL7x -----END PGP SIGNATURE----- --=-=-=--