From: Roel Janssen <roel@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] guix-daemon: Add option to disable garbage collection.
Date: Thu, 19 Apr 2018 19:07:23 +0200 [thread overview]
Message-ID: <87muxzw2es.fsf@gnu.org> (raw)
In-Reply-To: <87vacni5eb.fsf@gnu.org>
Ludovic Courtès <ludo@gnu.org> writes:
> Heya,
>
> Roel Janssen <roel@gnu.org> skribis:
>
>> From fcbe7ebb3d205cf7310700e62b78b9aafd94f76f Mon Sep 17 00:00:00 2001
>> From: Roel Janssen <roel@gnu.org>
>> Date: Thu, 19 Apr 2018 17:11:30 +0200
>> Subject: [PATCH] guix-daemon: Disable garbage collection for remote
>> connections.
>>
>> * nix/nix-daemon/nix-daemon.cc (isRemoteConnection): New variable.
>> (performOp): For wopCollectGarbage, throw an error when isRemoteConnection
>> is set.
>> (acceptConnection): Set isRemoteConnection when connection is not AF_UNIX.
>> * tests/guix-daemon.sh: Add a test for the new behavior.
>
> LGTM, thanks for the quick reply!
Awesome. Pushed in 5cefb13dd.
Thanks!
Kind regards,
Roel Janssen
next prev parent reply other threads:[~2018-04-19 17:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-03 10:12 [PATCH] guix-daemon: Add option to disable garbage collection Roel Janssen
2018-04-03 13:40 ` Ludovic Courtès
2018-04-03 14:02 ` Roel Janssen
2018-04-11 7:57 ` Roel Janssen
2018-04-17 21:00 ` Roel Janssen
2018-04-18 21:12 ` Ludovic Courtès
2018-04-19 9:06 ` Ludovic Courtès
2018-04-19 12:12 ` Roel Janssen
2018-04-19 14:47 ` Ludovic Courtès
2018-04-19 15:15 ` Roel Janssen
2018-04-19 15:26 ` Ludovic Courtès
2018-04-19 17:07 ` Roel Janssen [this message]
2018-04-19 15:25 ` Marius Bakke
-- strict thread matches above, loose matches on Subject: below --
2018-04-03 12:41 Adam Van Ymeren
2018-04-03 13:03 ` Roel Janssen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87muxzw2es.fsf@gnu.org \
--to=roel@gnu.org \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.