From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark H Weaver <mhw@netris.org>
Subject: Re: 01/01: gnu: Add guile-curl.
Date: Thu, 19 Apr 2018 08:20:51 -0400
Message-ID: <87muxzidzw.fsf@netris.org>
References: <20180418210130.32311.11971@vcs0.savannah.gnu.org>
	<20180418210131.A20A7204F1@vcs0.savannah.gnu.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44154)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1f98ZX-0007Jp-9Y
	for guix-devel@gnu.org; Thu, 19 Apr 2018 08:21:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1f98ZS-0006Si-CI
	for guix-devel@gnu.org; Thu, 19 Apr 2018 08:21:55 -0400
In-Reply-To: <20180418210131.A20A7204F1@vcs0.savannah.gnu.org> (Roel Janssen's
	message of "Wed, 18 Apr 2018 17:01:31 -0400 (EDT)")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Roel Janssen <roel@gnu.org>
Cc: guix-devel@gnu.org

Hi Roel,

roel@gnu.org (Roel Janssen) writes:

> roelj pushed a commit to branch master
> in repository guix.
>
> commit 5e3010a2ac651397e0cb69239a7d7aa3c0a5703e
> Author: Roel Janssen <roel@gnu.org>
> Date:   Wed Apr 18 23:00:41 2018 +0200
>
>     gnu: Add guile-curl.
>     
>     * gnu/packages/curl.scm (guile-curl): New variable.

[...]

> +      (modify-phases %standard-phases
> +        (add-after 'install 'patch-extension-path
> +          (lambda* (#:key outputs #:allow-other-keys)
> +             (let* ((out      (assoc-ref outputs "out"))
> +                    (curl.scm (string-append
> +                               out "/share/guile/site/2.2/curl.scm"))
> +                    (curl.go  (string-append
> +                               out "/lib/guile/2.2/site-ccache/curl.go"))
> +                    (ext      (string-append out "/lib/guile/2.2/"
> +                                             "extensions/libguile-curl")))
> +               (substitute* curl.scm (("libguile-curl") ext))
> +               ;; The build system does not actually compile the Scheme module.
> +               ;; So we can compile it and put it in the right place in one go.
> +               (system* "guild" "compile" curl.scm "-o" curl.go))
> +               #t)))))

Please use 'invoke' instead of 'system*' from now on, so that errors in
the subprocess will be detected and reported using exceptions.  As you
have it now, compile failures will be ignored.

Would you like to push a fix?

     Mark