Re: 01/01: gnu: Add guile-curl.

Re: 01/01: gnu: Add guile-curl.

[Mark H Weaver]

Hi Roel,

roel@gnu.org (Roel Janssen) writes:

> roelj pushed a commit to branch master
> in repository guix.
>
> commit 5e3010a2ac651397e0cb69239a7d7aa3c0a5703e
> Author: Roel Janssen <roel@gnu.org>
> Date:   Wed Apr 18 23:00:41 2018 +0200
>
>     gnu: Add guile-curl.
>     
>     * gnu/packages/curl.scm (guile-curl): New variable.

[...]

> +      (modify-phases %standard-phases
> +        (add-after 'install 'patch-extension-path
> +          (lambda* (#:key outputs #:allow-other-keys)
> +             (let* ((out      (assoc-ref outputs "out"))
> +                    (curl.scm (string-append
> +                               out "/share/guile/site/2.2/curl.scm"))
> +                    (curl.go  (string-append
> +                               out "/lib/guile/2.2/site-ccache/curl.go"))
> +                    (ext      (string-append out "/lib/guile/2.2/"
> +                                             "extensions/libguile-curl")))
> +               (substitute* curl.scm (("libguile-curl") ext))
> +               ;; The build system does not actually compile the Scheme module.
> +               ;; So we can compile it and put it in the right place in one go.
> +               (system* "guild" "compile" curl.scm "-o" curl.go))
> +               #t)))))

Please use 'invoke' instead of 'system*' from now on, so that errors in
the subprocess will be detected and reported using exceptions.  As you
have it now, compile failures will be ignored.

Would you like to push a fix?

     Mark

Re: 01/01: gnu: Add guile-curl.

[Roel Janssen]

Mark H Weaver <mhw@netris.org> writes:

> Hi Roel,
>
> roel@gnu.org (Roel Janssen) writes:
>
>> roelj pushed a commit to branch master
>> in repository guix.
>>
>> commit 5e3010a2ac651397e0cb69239a7d7aa3c0a5703e
>> Author: Roel Janssen <roel@gnu.org>
>> Date:   Wed Apr 18 23:00:41 2018 +0200
>>
>>     gnu: Add guile-curl.
>>     
>>     * gnu/packages/curl.scm (guile-curl): New variable.
>
> [...]
>
>> +      (modify-phases %standard-phases
>> +        (add-after 'install 'patch-extension-path
>> +          (lambda* (#:key outputs #:allow-other-keys)
>> +             (let* ((out      (assoc-ref outputs "out"))
>> +                    (curl.scm (string-append
>> +                               out "/share/guile/site/2.2/curl.scm"))
>> +                    (curl.go  (string-append
>> +                               out "/lib/guile/2.2/site-ccache/curl.go"))
>> +                    (ext      (string-append out "/lib/guile/2.2/"
>> +                                             "extensions/libguile-curl")))
>> +               (substitute* curl.scm (("libguile-curl") ext))
>> +               ;; The build system does not actually compile the Scheme module.
>> +               ;; So we can compile it and put it in the right place in one go.
>> +               (system* "guild" "compile" curl.scm "-o" curl.go))
>> +               #t)))))
>
> Please use 'invoke' instead of 'system*' from now on, so that errors in
> the subprocess will be detected and reported using exceptions.  As you
> have it now, compile failures will be ignored.

Whoops.  I will try to clear my brain's internal cache.
Thanks for letting me know.

>
> Would you like to push a fix?

I pushed a fix in d28e5ad23.

Kind regards,
Roel Janssen