From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45886) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fdto5-0000tp-FJ for guix-patches@gnu.org; Fri, 13 Jul 2018 04:52:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fdto2-0008Tj-E5 for guix-patches@gnu.org; Fri, 13 Jul 2018 04:52:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:49782) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fdto2-0008TY-9l for guix-patches@gnu.org; Fri, 13 Jul 2018 04:52:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fdto2-0001oe-2C for guix-patches@gnu.org; Fri, 13 Jul 2018 04:52:02 -0400 Subject: [bug#32121] [PATCH 4/5] database: Call a specification 'jobset' instead of 'project'. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20180710230247.16639-1-clement@lassieur.org> <20180710230247.16639-4-clement@lassieur.org> Date: Fri, 13 Jul 2018 10:51:16 +0200 In-Reply-To: <20180710230247.16639-4-clement@lassieur.org> ("=?UTF-8?Q?Cl=C3=A9ment?= Lassieur"'s message of "Wed, 11 Jul 2018 01:02:46 +0200") Message-ID: <87muuvldrv.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Cc: 32121@debbugs.gnu.org Cl=C3=A9ment Lassieur skribis: > This removes the possibility to filter specifications by branch, because > branches were previously called 'jobset'. But it doesn't matter because = later > on, specifications will have as many branches as inputs. And people shou= ld > filter by specification name instead. > > * doc/cuirass.texi (Build Information, Latest builds): Remove 'jobset', > replace 'project' with 'jobset'. > * src/cuirass/http.scm (build->hydra-build): Idem. > * tests/database.scm (db-get-builds): Idem. > * tests/http.scm (build-query-result, /api/latestbuilds?nr=3D1&jobset=3Dg= uix, > /api/latestbuilds?nr=3D1&jobset=3Dgnu): Idem. > * src/cuirass/database.scm (db-format-build, db-get-builds): Don't associ= ate > builds with branches (which were called 'jobset' afterwards). > (db-get-builds): Remove the #:project filter. To make sure I understand correctly: it=E2=80=99ll still be possible to hav= e, say, a =E2=80=9Cguix=E2=80=9D job or a =E2=80=9Cmodular=E2=80=9D job built = with several different branches, right? I think we should try to keep the HTTP API compatible with Hydra so we don=E2=80=99t break guix-hydra.el and possibly Tatiana=E2=80=99s work. WDYT? Ludo=E2=80=99.