From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jelle Licht <jlicht@fsfe.org>
Subject: Re: 07/07: gnu: emacs-ghub: Update to 3.2.0.
Date: Fri, 11 Jan 2019 13:49:25 +0100
Message-ID: <87muo7fjfu.fsf@fsfe.org>
References: <20190109214312.21187.54045@vcs0.savannah.gnu.org>
	<20190109214315.1BE5121122@vcs0.savannah.gnu.org>
	<87va2wia3e.fsf@netris.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([209.51.188.92]:56724)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jlicht@fsfe.org>) id 1ghwFm-0007jJ-8g
	for guix-devel@gnu.org; Fri, 11 Jan 2019 07:49:41 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jlicht@fsfe.org>) id 1ghwFl-0008IV-JD
	for guix-devel@gnu.org; Fri, 11 Jan 2019 07:49:38 -0500
Received: from mail1.fsfe.org ([217.69.89.151]:54368)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <jlicht@fsfe.org>) id 1ghwFl-0008HN-6V
	for guix-devel@gnu.org; Fri, 11 Jan 2019 07:49:37 -0500
In-reply-to: <87va2wia3e.fsf@netris.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org


Mark H Weaver <mhw@netris.org> writes:

> Hi Jelle,
> [...]
>
> In toplevel form:
> magit-reset.el:30:1:Error: Cannot open load file: No such file or directory, graphql
> make[1]: *** [Makefile:65: magit-reset.elc] Error 1
> make[1]: Leaving directory '/tmp/guix-build-emacs-magit-2.13.0.drv-0/magit-2.13.0/lisp'
> make: *** [Makefile:72: lisp] Error 2

I am not quite sure what goes wrong, but I do know that ghub and magit
should probably be updated in lockstep. I reverted the patch for now and
will push it once I have verified other things still work. Later I will
update everything at once when emacs-forge is properly released.

BTW, how does our one-change-per-patch policy apply when running into
situations where multiple changes have to be made at once in order to
keep everything building correctly?

Thanks,

- Jelle