Re: 07/07: gnu: emacs-ghub: Update to 3.2.0.

Re: 07/07: gnu: emacs-ghub: Update to 3.2.0.

[Mark H Weaver]

Hi Jelle,

guix-commits@gnu.org writes:

> jlicht pushed a commit to branch master
> in repository guix.
>
> commit b96f0e6ff9f8f36d250b5ae94a908272babb35cf
> Author: Jelle Licht <jlicht@fsfe.org>
> Date:   Sat Dec 29 14:55:19 2018 +0100
>
>     gnu: emacs-ghub: Update to 3.2.0.
>     
>     * gnu/packages/emacs.scm (emacs-ghub): Update to 3.2.0.
>     [source]: Use 'git-fetch'.
>     [propagated-inputs]: Add emacs-dash, emacs-graphql,
>     emacs-let-alist, emacs-treepy.

This commit broke the 'emacs-magit' build:

  https://hydra.gnu.org/build/3332282

See below for an excerpt of the failed build log.  Reverting the
'emacs-ghub' update fixes the problem.

Can you take a look?

     Thanks,
       Mark


--8<---------------cut here---------------start------------->8---
Compiling magit-log.el
Compiling magit-wip.el
Compiling magit-apply.el
Compiling magit.el
Compiling magit-status.el
Compiling magit-refs.el
Compiling magit-files.el
Compiling magit-collab.el
Compiling magit-reset.el
Compiling magit-merge.el
Compiling magit-tag.el
Compiling magit-worktree.el

In toplevel form:
magit-files.el:33:1:Error: Cannot open load file: No such file or directory, graphql
make[1]: *** [Makefile:65: magit-files.elc] Error 1

In toplevel form:
magit-status.el:30:1:Error: Cannot open load file: No such file or directory, graphqlmake[1]: *** Waiting for unfinished jobs....

make[1]: *** [Makefile:65: magit-status.elc] Error 1

In toplevel form:
magit-merge.el:30:1:Error: Cannot open load file: No such file or directory, graphql
make[1]: *** [Makefile:65: magit-merge.elc] Error 1

In toplevel form:
magit-collab.el:37:1:Error: Cannot open load file: No such file or directory, graphql
make[1]: *** [Makefile:65: magit-collab.elc] Error 1

In toplevel form:
magit-tag.el:30:1:Error: Cannot open load file: No such file or directory, graphql
In toplevel form:
magit-worktree.el:33:1:Error: Cannot open load file: No such file or directory, graphql
make[1]: *** [Makefile:65: magit-worktree.elc] Error 1

make[1]: *** [Makefile:65: magit-tag.elc] Error 1

In toplevel form:
magit-refs.el:30:1:Error: Cannot open load file: No such file or directory, graphql
make[1]: *** [Makefile:65: magit-refs.elc] Error 1

In toplevel form:
magit-reset.el:30:1:Error: Cannot open load file: No such file or directory, graphql
make[1]: *** [Makefile:65: magit-reset.elc] Error 1
make[1]: Leaving directory '/tmp/guix-build-emacs-magit-2.13.0.drv-0/magit-2.13.0/lisp'
make: *** [Makefile:72: lisp] Error 2
--8<---------------cut here---------------end--------------->8---

Re: 07/07: gnu: emacs-ghub: Update to 3.2.0.

[Jelle Licht]

Mark H Weaver <mhw@netris.org> writes:

> Hi Jelle,
> [...]
>
> In toplevel form:
> magit-reset.el:30:1:Error: Cannot open load file: No such file or directory, graphql
> make[1]: *** [Makefile:65: magit-reset.elc] Error 1
> make[1]: Leaving directory '/tmp/guix-build-emacs-magit-2.13.0.drv-0/magit-2.13.0/lisp'
> make: *** [Makefile:72: lisp] Error 2

I am not quite sure what goes wrong, but I do know that ghub and magit
should probably be updated in lockstep. I reverted the patch for now and
will push it once I have verified other things still work. Later I will
update everything at once when emacs-forge is properly released.

BTW, how does our one-change-per-patch policy apply when running into
situations where multiple changes have to be made at once in order to
keep everything building correctly?

Thanks,

- Jelle

Re: 07/07: gnu: emacs-ghub: Update to 3.2.0.

[Mark H Weaver]

Jelle Licht <jlicht@fsfe.org> writes:

> Mark H Weaver <mhw@netris.org> writes:
>
>> Hi Jelle,
>> [...]
>>
>> In toplevel form:
>> magit-reset.el:30:1:Error: Cannot open load file: No such file or directory, graphql
>> make[1]: *** [Makefile:65: magit-reset.elc] Error 1
>> make[1]: Leaving directory '/tmp/guix-build-emacs-magit-2.13.0.drv-0/magit-2.13.0/lisp'
>> make: *** [Makefile:72: lisp] Error 2
>
> I am not quite sure what goes wrong, but I do know that ghub and magit
> should probably be updated in lockstep. I reverted the patch for now and
> will push it once I have verified other things still work. Later I will
> update everything at once when emacs-forge is properly released.

Sounds good, thanks.

> BTW, how does our one-change-per-patch policy apply when running into
> situations where multiple changes have to be made at once in order to
> keep everything building correctly?

In this case, I would keep them as separate commits, but push them at
the same time.

      Thanks!
        Mark