From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:58987) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gth4x-0002XX-Io for guix-patches@gnu.org; Tue, 12 Feb 2019 18:03:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gth4w-0004gk-SZ for guix-patches@gnu.org; Tue, 12 Feb 2019 18:03:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:46101) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gth4w-0004g0-EK for guix-patches@gnu.org; Tue, 12 Feb 2019 18:03:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gth4w-0007Lb-9R for guix-patches@gnu.org; Tue, 12 Feb 2019 18:03:02 -0500 Subject: bug#34435: [PATCH 3/3] gnu: Add kscreenlocker. Resent-To: guix-patches@gnu.org Resent-Message-ID: From: Marius Bakke In-Reply-To: References: <20190211151835.18653-1-mbakke@fastmail.com> <20190211151835.18653-3-mbakke@fastmail.com> Date: Wed, 13 Feb 2019 00:02:12 +0100 Message-ID: <87mun0wqyz.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Hartmut Goebel , 34435-done@debbugs.gnu.org --=-=-= Content-Type: text/plain Hartmut Goebel writes: > Am 11.02.19 um 16:18 schrieb Marius Bakke: >> + (native-inputs >> + `(("extra-cmake-modules" ,extra-cmake-modules) >> + ("pkg-config" ,pkg-config) >> + > > Empty line. I like adding empty lines to "group" inputs, or as a separator to make some things "stand out". >> + ("logind" ,elogind) ;optional loginctl support > > According to my notes (for 5.13.5) this is a run-time dependency. Why do > we need to list it here and not later in some "service"? CMake tests for it, and sets HAVE_UNLOCK_CAPABILITY to TRUE when found. I did not study the code enough to see how it is used so I left it in for now. > Another thing: I suggest keeping al l Plasma related packages in a > module of it's own. This will help keeping modules small, easy to spot > and easier to maintain. I moved the Plasma packages to a kde-plasma module with commit bec2a2e10e199d6ee671ec5713bd103242e91b62. Thanks for the feedback! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlxjUHQACgkQoqBt8qM6 VPoRnggAyv1fjOf335orxv14PzRLA//T0zX1PSu/Cgkrx8VIlYIcz2/Dx43IFJ6x dSpcFnuXkTgJ3+Brpxs+D/GMBhfEe/eap19kH0uzt6KpAwH6rOWG+CcW9wPXRiKT AQoVStvzChbEu+W0p9T62u+aEE8nWB0hFY0oYUWwGgf/ZNLfOyZrWIcFSa36Dybc EJvWcO8pd7zdX5cuiwRdwUb57TEF/kT2IOmfYOU1cieDOsSuAKDD9bbABOxzL6bQ uHESsk0X3S+3lVsAFkgiByShhnnbW1gxgqhTXw9Ab9h23WDAoAUA2mw1zhn9Z6Bb 2J/Wb19DA1WjSRHKMFiaccKK0vIgdQ== =/AoH -----END PGP SIGNATURE----- --=-=-=--