From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: bug#34531: Guix profile fails on Overdrive 1000
Date: Tue, 26 Feb 2019 22:07:06 +0100
Message-ID: <87mumiz2bp.fsf@elephly.net>
References: <20190218200552.GB1881@jurong> <87mumsom9l.fsf@fastmail.com>
	<20190219082728.GA5650@jurong> <87lg2bvrne.fsf@elephly.net>
	<20190219161954.47234638@scratchpost.org>
	<20190220115136.422bdf5b@scratchpost.org> <87va1eu1gp.fsf@elephly.net>
	<20190220142634.56868dba@scratchpost.org> <87k1hutpvw.fsf@elephly.net>
	<20190220172603.1a675f61@scratchpost.org> <87a7iq5gh8.fsf@elephly.net>
	<20190220230857.2282d9b1@scratchpost.org> <87ef7y3g61.fsf@elephly.net>
	<20190224114034.5f339ae3@scratchpost.org> <878sy52yw1.fsf@elephly.net>
	<20190224131204.21fdc1e5@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([209.51.188.92]:37408)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gyjxQ-00066J-RJ
	for bug-guix@gnu.org; Tue, 26 Feb 2019 16:08:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gyjxP-0007dJ-OU
	for bug-guix@gnu.org; Tue, 26 Feb 2019 16:08:08 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:39791)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gyjxL-0007ac-A5
	for bug-guix@gnu.org; Tue, 26 Feb 2019 16:08:06 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gyjxL-0006FZ-16
	for bug-guix@gnu.org; Tue, 26 Feb 2019 16:08:03 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.34531.B34531.155121524623977@debbugs.gnu.org>
In-reply-to: <20190224131204.21fdc1e5@scratchpost.org>
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 34531@debbugs.gnu.org


Hi Danny,

>> The loop looks a bit more complicated than it needs to be, I think.  Did
>> my version not work for you?
>
> It did, but I wanted to make sure the port did exactly the same as the
> original generate.py--maybe I overdid it, but I didn't want to break it
> by porting it.
>
> What skip_comments in the original does is strip comments, but not strip
> "comment-like things" that are in string literals ("/*blah*/").
> (as far as I can tell, at least)

Ah, I see.  If your version works fine I think it=E2=80=99s worth using it =
to
replace the need for Python here.

I=E2=80=99d probably implement this somewhat differently (to remove the
=E2=80=9Calmost*=E2=80=9D symbols and to cut down on duplication), but I do=
n=E2=80=99t think
it=E2=80=99s worth polishing this when the main purpose has been achieved.

Thanks for tackling this!

--=20
Ricardo