From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:50818)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hOl9T-0004eY-Hy
	for guix-patches@gnu.org; Thu, 09 May 2019 11:40:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hOl9O-0002Mf-Rp
	for guix-patches@gnu.org; Thu, 09 May 2019 11:40:07 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:50813)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1hOl9O-0002MZ-Oh
	for guix-patches@gnu.org; Thu, 09 May 2019 11:40:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hOl9O-00080b-LF
	for guix-patches@gnu.org; Thu, 09 May 2019 11:40:02 -0400
Subject: [bug#35652] [PATCH] services: dhcp-client: Ignore non-ARP network
	interfaces.
Resent-Message-ID: <handler.35652.B35652.155741637530722@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <87d0krd4s6.fsf@fastmail.com>
Date: Thu, 09 May 2019 17:39:25 +0200
In-Reply-To: <87d0krd4s6.fsf@fastmail.com> (Marius Bakke's message of "Thu, 09
	May 2019 17:30:17 +0200")
Message-ID: <87mujvd4cy.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 35652@debbugs.gnu.org

Hi Marius,

Good catch!

Marius Bakke <mbakke@fastmail.com> skribis:

> From 7724f24443392fdfc2c075909d9b64350f6578b2 Mon Sep 17 00:00:00 2001
> From: Marius Bakke <mbakke@fastmail.com>
> Date: Thu, 9 May 2019 17:03:03 +0200
> Subject: [PATCH] services: dhcp-client: Ignore interfaces that are not ARP
>  capable.
>
> * guix/build/syscalls.scm (IFF_NOARP): New variable.
> (arp-network-interface?): New public variable.
> * gnu/services/networking.scm (dhcp-client-service-type): Filter interfac=
es
> that do not support the ARP protocol.

Could you make it two patches (one for syscalls.scm, and another one for
the rest)?

Otherwise LGTM, thank you!

Ludo=E2=80=99.