From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@gnu.org>
Subject: Re: branch master updated: gnu: ode: Disable tests.
Date: Tue, 28 Jan 2020 11:23:49 +0100
Message-ID: <87mua7j2ve.fsf@gnu.org>
References: <20200124214907.26770.54455@vcs0.savannah.gnu.org>
 <87blqrbowp.fsf@gnu.org> <87k15fnzlz.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:45793)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <ludo@gnu.org>) id 1iwO2E-0002gB-Ho
 for guix-devel@gnu.org; Tue, 28 Jan 2020 05:23:55 -0500
In-Reply-To: <87k15fnzlz.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of
 "Sat, 25 Jan 2020 19:46:16 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
 <guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org
Sender: "Guix-devel"
 <guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: guix-devel@gnu.org

Hi,

Nicolas Goaziou <mail@nicolasgoaziou.fr> skribis:

> Ludovic Court=C3=A8s <ludo@gnu.org> writes:
>
>> What about disabling tests only on those platforms=20
>
> I didn't realize that was possible. Hopefully, commit
> 5b7fdc8289ce0adf85e881bc23d3537121b41193 fixes this.

It does, thanks!  One minor issue:

+     ;; Tests fail on all systems but x86_64.
+     `(#:tests? ,(string=3D? "x86_64-linux"
+                           (or (%current-target-system)
+                               (%current-system)))

This should rather be:

  (string-prefix? "x86_64-" (or (%current-target-system) (%current-system)))

because =E2=80=98%current-target-system=E2=80=99 is a triplet (like =E2=80=
=9Carm-linux-gnueabihf=E2=80=9D)
whereas =E2=80=98%current-system=E2=80=99 is a =E2=80=9Csystem type=E2=80=
=9D (like =E2=80=9Cx86_64-linux=E2=80=9D).

Ludo=E2=80=99.