From: "Ludovic Courtès" <ludo@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: guix-devel@gnu.org
Subject: Re: branch master updated: gnu: ode: Disable tests.
Date: Tue, 28 Jan 2020 11:23:49 +0100 [thread overview]
Message-ID: <87mua7j2ve.fsf@gnu.org> (raw)
In-Reply-To: <87k15fnzlz.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Sat, 25 Jan 2020 19:46:16 +0100")
Hi,
Nicolas Goaziou <mail@nicolasgoaziou.fr> skribis:
> Ludovic Courtès <ludo@gnu.org> writes:
>
>> What about disabling tests only on those platforms
>
> I didn't realize that was possible. Hopefully, commit
> 5b7fdc8289ce0adf85e881bc23d3537121b41193 fixes this.
It does, thanks! One minor issue:
+ ;; Tests fail on all systems but x86_64.
+ `(#:tests? ,(string=? "x86_64-linux"
+ (or (%current-target-system)
+ (%current-system)))
This should rather be:
(string-prefix? "x86_64-" (or (%current-target-system) (%current-system)))
because ‘%current-target-system’ is a triplet (like “arm-linux-gnueabihf”)
whereas ‘%current-system’ is a “system type” (like “x86_64-linux”).
Ludo’.
next prev parent reply other threads:[~2020-01-28 10:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200124214907.26770.54455@vcs0.savannah.gnu.org>
2020-01-25 14:18 ` branch master updated: gnu: ode: Disable tests Ludovic Courtès
2020-01-25 18:46 ` Nicolas Goaziou
2020-01-28 10:23 ` Ludovic Courtès [this message]
2020-01-28 19:27 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mua7j2ve.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.